1801215 - Findbar labels appear even if no checkbox is ticked

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[Itiel]

Attachment: Screenshot

Comment 1

[Itiel]

Attachment: Bug 1801215 - Decrease value/description[crop] specifity to allow disabled item to actually be disabled r?emilio

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ab96a1473055
Decrease value/description[crop] specifity to allow disabled item to actually be disabled r=emilio

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1799460

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/ab96a1473055

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:itiel_yn8, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox108 to wontfix.

For more information, please visit auto_nag documentation.

Comment 6

[Itiel]

Comment on attachment 9303982 [details]
Bug 1801215 - Decrease value/description[crop] specifity to allow disabled item to actually be disabled r?emilio

Beta/Release Uplift Approval Request

• User impact if declined: Labels/descriptions appear even if they shouldn't, like in the findbar.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Open the findbar and without searching for anything or checking any of the checkboxes, make sure that the labels that usually appear after the "Whole words" checkbox, don't appear (and that they appear only when when appropriate).
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): A one-liner to decrease specifity of the newly added rule in the regressing bug, to allow other rule that disable labels to take effect.
• String changes made/needed:
• Is Android affected?: Unknown

Comment 7

[Dianna Smith [:diannaS]]

:Itiel hi, it looks like the nominated patch was built on top of bug 1801113 and the latest commits of bug 1799460. This doesn't graft cleanly to beta since part of the code doesn't yet exist in 108.

Please feel free to NI me/re-nominate if we need to revisit this with a rebased patch or if we need to uplift other dependencies as well.

Comment 8

[Itiel]

Ah sorry, I thought ALL of the patches landed in beta (and not just https://phabricator.services.mozilla.com/D162039). My bad.

Comment 9

[Alin Ilea, Desktop Test Engineering]

Reproduced the issue in Nightly 109.0a1 (build id: 20221117093901) using Windows 10.
Verified - Fixed in latest Nightly 109.0a1 (build id: 20221120214001) on Windows 10, macOS 12 and Ubuntu 20.