1801286 - Going offline closes connection before POP3 QUIT command is processed

Status: RESOLVED FIXED

(MailNews Core :: Networking: POP, defect)

Description

[hkallweit1]

Steps to reproduce:

I use POP3 to retrieve mail from multiple mail providers.
Issue occurs when I go offline in Thunderbird what triggers fetching mail from all providers. "Leave messages on server" is disabled.
Issue does not happen when fetching mail via Shift+F5 whilst being online.

Actual results:

Retrieving mail from Gmail doesn't delete the mail on the server. Therefore next time the same mail are re-downloaded. Note that the issue may not be related to Gmail as such, but caused by the fact that Gmail is the last provider processed.

POP3 traffic log shows that seemingly the connection is closed before the QUIT command is processed. Response from server is missing and error number indicates premature offline state (Decimal status code is 0x804b0010 = NS_ERROR_OFFLINE).

mailnews.pop3.11: C: DELE 1 Pop3Client.jsm:473:20
mailnews.pop3.11: S: +OK marked for deletion Pop3Client.jsm:330:18
mailnews.pop3.11: Folder lock released. Pop3Client.jsm:1206:22
mailnews.pop3.11: Done with status=0 Pop3Client.jsm:1432:18
mailnews.pop3.11: C: QUIT Pop3Client.jsm:473:20
mailnews.pop3.11: Done with status=2152398864 Pop3Client.jsm:1432:18
mailnews.pop3.11: Connection closed.

Expected results:

Retrieved mails are deleted on Gmail server.

Comment 1

[Ping Chen [:rnons] (away)]

Attachment: Bug 1801286 - Wait for QUIT response in Pop3Client.jsm. r=mkmelin

Comment 2

[Ping Chen [:rnons] (away)]

I see the same logs as comment 0, but I don't have duplicate message problem. Anyway, the patch should fix it. Thanks for reporting.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/ce7822519deb
Wait for QUIT response in Pop3Client.jsm. r=mkmelin

Comment 4

[Ping Chen [:rnons] (away)]

Attachment: Bug 1801286 follow-up - Fix for browser_mailAccountSetupWizard.js. r=mkmelin

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/16b1ea6fa707
follow-up - Fix for browser_mailAccountSetupWizard.js. r=mkmelin

Comment 6

[Rob Lemley [:rjl]]

Comment on attachment 9304213 [details]
Bug 1801286 - Wait for QUIT response in Pop3Client.jsm. r=mkmelin

[Triage Comment]
Approved for 102 with wmwsk via Matrix.

Comment 7

[Rob Lemley [:rjl]]

Comment on attachment 9305243 [details]
Bug 1801286 follow-up - Fix for browser_mailAccountSetupWizard.js. r=mkmelin

[Triage Comment]
Approved

Comment 8

[Daniel Darnell [:dandarnell]]

Thunderbird 102.11.2:
https://hg.mozilla.org/releases/comm-esr102/rev/c715064ce573
https://hg.mozilla.org/releases/comm-esr102/rev/eaed14cf51e1