180134 - NS_METHOD nsWindow::ConstrainPosition needs impelentation in BeOS

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[Sergei Dolgov]

BeZilla users frequently complain about sitation when browser goes in
fullscreen-like state (but F11 don't work), so they should remove localstore.rdf
to restore normal size and position.

Comment 1

[Paul]

taking

Comment 2

[Paul]

taking

Comment 3

[Paul]

Attachment: implement constrainposition

ConstrainPosition implementation

Comment 4

[Paul]

Comment on attachment 119927 [details] [diff] [review]
implement constrainposition

Sergei, can you review this?

Comment 5

[Sergei Dolgov]

That's good you proposed this. My current implementation of method was much simpler:

{
  if (eWindowType_dialog != mWindowType && eWindowType_toplevel != mWindowType)
    return NS_OK;
  if(*aX <=0)
    *aX=2;
  if(*aY <=0)
    *aY=20;
  return NS_OK;
}
Probably your version is more intelligent. Will try it

Comment 6

[Paul]

this is based on the gtk version, and also uses the allowSlop boolean passed in

Comment 7

[Paul]

Attachment: updated patch

Updated patch:
- Takes into account window borders and the title bar 
  - these values are defined as constants, since BeOS does not provide them
  - the title bar height is the height of the tallest title bar under BeOS
    (that I can find)
- Only deals with dialogs and windows now

Comment 8

[Sergei Dolgov]

Paul, it seems something happened when you created last patch, and it misses now
 both declaration of mIsTopWidgetWindow (nsWindow.h) and assignment of  values
to it, initiall, and real (nsWindow.cpp)

Comment 9

[Sergei Dolgov]

Another notice Paul, what do you think about changing style from

foo {
}

to 

foo
{
}

everywhere in BeOS code?
Personally i can't stand first style...

Comment 10

[Paul]

nope, that variable existed before my original patch, but was never used.  So 
I, since it was set the same way as the windows port, I backed out my "new" 
variable, and am using the previously "unused" variable.

as far as style changes, personally, I don't care.  I can read the code either 
way.  I usually write my code using the first style, because I'm a java dev :-
)  But, that doesn't mean i have to.

Comment 11

[Sergei Dolgov]

Comment on attachment 120041 [details] [diff] [review]
updated patch

Works well here, reviewing

Comment 12

[Paul]

this has been checked in