Closed Bug 1801349 Opened 1 year ago Closed 1 year ago

Sentry breadcrumbs have invalid timestamps and are sometimes are repeated / out of order

Categories

(Fenix :: General, defect)

All
Android
defect

Tracking

(firefox110 fixed)

RESOLVED FIXED
Tracking Status
firefox110 --- fixed

People

(Reporter: bdk, Assigned: bdk)

References

Details

Attachments

(2 files)

The app-services code has started to use breadcrumbs more to understand the context for our bugs. It's been pretty useful overall, but we've noticed some issues:

  • Almost all breadcrumbs seem to have the same timestamp
  • The breadcrumb list is not reliable. It seems like breadcrumbs are duplicated and/or out of order.

See this Sentry event for an example:
https://sentry.io/organizations/mozilla/issues/3727379779/events/9642444643484fbe9f6fea47ee510e7a/?project=6295546&query=is%3Aunresolved+rusterrors&referrer=previous-event&sort=freq&statsPeriod=14d

Note that we added an atomic counter on all our breadcrumbs, that's displayed as (N) at the end of each message. You can see instances where messages are duplicated. There are also instances where the messages are out of order, which may or may not indicate an issue.

Assignee: nobody → bdeankawamura

Re-opening with the partial backout that requires some discussions: https://github.com/mozilla-mobile/firefox-android/pull/269

Status: RESOLVED → REOPENED
Resolution: FIXED → ---

(In reply to Ben Dean-Kawamura [:bdk])

Does that note about iteration apply to the clone() method? I believe the only methods being called are clone(), add(), and remove().

Building on Petru's idea, we may need to clone (pun intended) the Collections.synchronizedList and SynchronizedList to wrap the clone method in a mutex like the other calls. We can put that in the support-base component if we go that direction.

This is probably overkill, but given that we have code to limit the breadcrumb list to N elements something like a ring buffer would be ideal. Do we have access to anything like that?

(In reply to Ben Dean-Kawamura [:bdk] from comment #5)

This is probably overkill, but given that we have code to limit the breadcrumb list to N elements something like a ring buffer would be ideal. Do we have access to anything like that?

Not to my knowledge, but would that solve the problem where multiples accessors add to the breadcrumbs in the wrong order?

Status: REOPENED → RESOLVED
Closed: 1 year ago1 year ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: