1801545 - Firefox devtools: allow changing values with mouse scroll

Status: RESOLVED FIXED

(DevTools :: Inspector: Rules, enhancement)

Description

[soredake]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:106.0) Gecko/20100101 Firefox/106.0

Steps to reproduce:

I've tried changing values of properties with mouse scroll in firefox devtools

Actual results:

It doesn't work, it just scrolled element rules.

Expected results:

Mouse scroll should change property value, like in chromium-based browsers.

Comment 1

[soredake]

Attachment: firefox can't change values with mouse scroll

Comment 2

[soredake]

Attachment: edge can change values with scroll

Comment 3

[soredake]

I've added videos to describe what i want to have in firefox devtools.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'DevTools::General' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 5

[soredake]

Additionally, in chrome, if you hold ALT while doing scrolling it will change values by 0.1, if you hold SHIFT it will change it by 10, if you hold CTRL it will change value by 100

Comment 6

[Christian Sonne [:cers]]

Attachment: Implement wheel events on inplace-editor

I'm still trying to figure out how to use phabricator, so for now I hope you will take a patch from here.

As far as I can tell, this implementation should match the behavior from Chrome

Comment 7

[Christian Sonne [:cers]]

Can you confirm that this is a bug we want to fix in the first place?

Comment 8

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Julian, this sounds like a nice improvement. Could you please look at the patch?

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee is inactive on Bugzilla, so the assignee is being reset.

Comment 10

[Julian Descottes [:jdescottes]]

Comment on attachment 9317333 [details] [diff] [review]
Implement wheel events on inplace-editor

The patch looks good, we would need a test.

Christian: sorry about the delay here, are you still interested in finishing this up?

Comment 11

[BugBot [:suhaib / :marco/ :calixte]]

Redirect a needinfo that is pending on an inactive user to the triage owner.
:jdescottes, since the bug has recent activity, could you please find another way to get the information or close the bug as INCOMPLETE if it is not actionable?

For more information, please visit BugBot documentation.

Comment 12

[Julian Descottes [:jdescottes]]

Will rebase the patch and try to add a test.

Comment 13

[Julian Descottes [:jdescottes]]

Attachment: Bug 1801545 - [devtools] Use mouse scroll to update values in inplace-editor

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7c04494909fc
[devtools] Use mouse scroll to update values in inplace-editor r=devtools-reviewers,nchevobbe

Comment 15

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/7c04494909fc