1801581 - getBoundingClientRect returns the wrong size for fixed position SVG content since bug 1340715

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[Brian Birtles (:birtles)]

Attachment: test.html

See the attached test case. In Chrome and previous versions of Firefox this produced a bounding box 300px wide but in recent versions of Firefox the bounding box has zero width.

Mozregression points to bug 1340715.

Comment 1

[Brian Birtles (:birtles)]

Even without running the JS, you can see that the bbox has zero width when you highlight <div id=div> in the DevTools.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1340715

:TYLin, since you are the author of the regressor, bug 1340715, could you take a look? Also, could you set the severity field?

For more information, please visit auto_nag documentation.

Comment 3

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Re comment 0:

See the attached test case. In Chrome and previous versions of Firefox this produced a bounding box 300px wide but in recent versions of Firefox the bounding box has zero width.

Yes, Chrome 110 produces a bounding box of 300px width, but any Firefox version before bug 1340715 produces a bounding box of the current window width.

Comment 4

[Brian Birtles (:birtles)]

300px still seems preferable to 0px as (a) it would match Chrome and (b) wouldn't confuse code trying to detect hidden elements.

Comment 5

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1801581 - Make preferred isize of SVG with no preferred aspect-ratio fall back to fallback intrinsic size.

To match blink and webkit's behavior.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cb640b83609b
Make preferred isize of SVG with no preferred aspect-ratio fall back to fallback intrinsic size. r=firefox-svg-reviewers,emilio,dholbert

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/37745 for changes under testing/web-platform/tests

Comment 8

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/cb640b83609b

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:TYLin, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox109 to wontfix.

For more information, please visit auto_nag documentation.

Comment 12

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

This bug fixed a regression. The patch in the original bug is too risky for a uplift, so does this patch.

Comment 13

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1801581 - Make preferred isize of SVG with fit-content value fall back to fallback intrinsic size. r?#firefox-svg-reviewers

This makes Firefox behave like Google Chrome.

Comment 14

[BugBot [:suhaib / :marco/ :calixte]]

A patch has been attached on this bug, which was already closed. Filing a separate bug will ensure better tracking. If this was not by mistake and further action is needed, please alert the appropriate party. (Or: if the patch doesn't change behavior -- e.g. landing a test case, or fixing a typo -- then feel free to disregard this message)

Comment 15

[Emilio Cobos Álvarez (:emilio)]

Yeah, wrong bug?

Comment 16

[Phabricator Automation]

Comment on attachment 9317550 [details]
Bug 1801581 - Make preferred isize of SVG with fit-content value fall back to fallback intrinsic size. r?#firefox-svg-reviewers

Revision D169778 was moved to bug 1811683. Setting attachment 9317550 [details] to obsolete.

Comment 17

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #15)

Yeah, wrong bug?

Oops, the patch is for bug 1811683.