1801591 - Enable eslint-plugin-eslint-plugin for eslint-plugin-mozilla

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, task, P3)

Description

[Mark Banner (:standard8)]

eslint-plugin-eslint-plugin is a small module that provides checks of ESLint rules themselves, e.g. checks against using obsolete APIs or missing metadata.

I think this would be useful to have as it currently shows up some usage of obsolete APIs, but generally ongoing these look to be useful checks to have when writing new rules.

Comment 1

[Mark Banner (:standard8)]

eslint-plugin-eslint-plugin is license compatible: https://npmgraph.js.org/?q=eslint-plugin-eslint-plugin

Comment 3

[Mark Banner (:standard8)]

Try push: https://treeherder.mozilla.org/jobs?repo=try&revision=2508c34eba044c55993ce1fbc3ed616b56aea52a

Comment 4

[Mark Banner (:standard8)]

Attachment: Bug 1801591 - Add missing schema definitions to eslint-plugin-mozilla rule metadata. r?Mossop!

This helps ESLint validate that rules aren't being passed extra parameters when we aren't expecting them,
and fixes the eslint-plugin/require-meta-schema rule failures.

Comment 5

[Mark Banner (:standard8)]

Attachment: Bug 1801591 - Automatically fix eslint-plugin-eslint-plugin raised issues for our eslint-plugin-mozilla rules. r?Mossop!

Depends on D168234

Comment 6

[Mark Banner (:standard8)]

Attachment: Bug 1801591 - Add eslint-plugin-eslint-plugin for linting our ESLint plugin rules, and upgrade most of node_modules. r?Mossop!

Depends on D168235

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5046f9a4bcff
Add missing schema definitions to eslint-plugin-mozilla rule metadata. r=mossop
https://hg.mozilla.org/integration/autoland/rev/270f89f1b2d5
Automatically fix eslint-plugin-eslint-plugin raised issues for our eslint-plugin-mozilla rules. r=mossop
https://hg.mozilla.org/integration/autoland/rev/ced89705dbf2
Add eslint-plugin-eslint-plugin for linting our ESLint plugin rules, and upgrade most of node_modules. r=mossop

Comment 8

[Mark Banner (:standard8)]

Attachment: Bug 1801591 - Add schema definition for ESLint rule no-redeclare-with-import-autofix.js

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cccc70a862a5
Add schema definition for ESLint rule no-redeclare-with-import-autofix.js CLOSED TREE

Comment 10

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/5046f9a4bcff
https://hg.mozilla.org/mozilla-central/rev/270f89f1b2d5
https://hg.mozilla.org/mozilla-central/rev/ced89705dbf2
https://hg.mozilla.org/mozilla-central/rev/cccc70a862a5