1801632 - Firefox fails to commit Wayland xdg_surface after ack_configure

Status: UNCONFIRMED

(Core :: Widget: Gtk, defect, P3)

Description

[[:nickname] Po Lu]

Attachment: Wayland compositor log

Firefox sometimes fails to commit an xdg_surface it creates after sending ack_configure. This results in the surface contents sometimes not being displayed after a resize finishes.

Attached is the compositor log demonstrating the incorrect behavior. After xdg_surface.configure (106) is sent, Firefox does not commit the associated xdg_surface, so the surface contents remain frozen. However, it does commit a desynchronous subsurface that is a child of the xdg_surface, which is not what the xdg_shell protocol says should be done in reply to an xdg_surface.configure event.

The log was generated with WebRender compositor integration enabled, but also happens without.

Comment 1

[Martin Stránský [:stransky] (ni? me)]

Which Wayland compositor do you run?

Comment 2

[[:nickname] Po Lu]

One I'm currently writing, but AFAICT from the log it isn't doing anything wrong (like not running frame callbacks.)

Comment 3

[Martin Stránský [:stransky] (ni? me)]

Does it have any visible consequences? i.e. do you see missing windows or so? Is there any testcase available?

Comment 4

[[:nickname] Po Lu]

Yes, Firefox freezes until another configure event is generated, at which point it does commit.

WDYM by test-case?

Thanks.

Comment 5

[Martin Stránský [:stransky] (ni? me)]

Sorry but I fail to imagine how it looks like on user end. Is part of window missing after resize or so? How can I reproduce it? May you create a screencast of it, how it looks like?

Comment 6

[[:nickname] Po Lu]

Attachment: Screencast from 2022-11-25 08-47-45.webm

Comment 7

[[:nickname] Po Lu]

The visible consequence is that the window contents "freeze" until the next configure event has a chance to make Firefox call commit, at which point the compositor resumes processing damage from the window. I've attached a screencast showing the problem. Thanks.

Comment 8

[Martin Stránský [:stransky] (ni? me)]

Interesting. I haven't seen such behavior in Mutter/KDE. Which compositor is that?

Comment 9

[Darkspirit]

(In reply to [:nickname] Po Lu from comment #2)

One I'm currently writing

Is it based on wlroots or completely custom? Is it on Github? Does the problem still occur with https://nightly.mozilla.org?