1801695 - Remove SourceMapService in favor of SourceMapLoader

Status: RESOLVED FIXED

(DevTools :: Debugger, task)

Description

[Alexandre Poirot [:ochameau]]

Today there is an intermediate layer called "SourceMapService", built from the toolbox class:
https://searchfox.org/mozilla-central/rev/83b86005c6913c2062419efb8aabdf2e683aa47f/devtools/client/framework/toolbox.js#1380-1454

This uses JS Proxy to hack the SourceMapLoader layer. Instead these hacks should be distributed into either SourceMapLoader or the callsites.

Also, we could simplify the SourceMapLoader by:

• using the regular DevTools Loader to load it
• store the various worker module URLs in the "index.js" files instead of requiring the callsites to know the worker url.
• rename sourceMapService to sourceMapLoader (this will clarify a bit more the difference between SourceMapLoader and SourceMapURLService).

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1801695 - [devtools] Use ChromeWorker for devtools frontend workers.

This allows using a regular worker and no longer have to be related to any particular document.

Comment 2

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1801695 - [devtools] Store worker URL in their index.js module instead of callsite.

This simplify the frontend code/callsites by not having to know where the worker file is.

Comment 3

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1801695 - [devtools] Use regular devtools loader to load SourceMap modules.

Now that source-map-loader uses ChromeLoader, it doesn't need to be loaded
via the Browser Loader. It was mostly used to be able to access window.Worker symbol.

It was also exposing fetch global symbol. DevTools Loader wasn't exposing it.
I fixed that as this symbol is available in JSM/ESM.

Comment 4

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1801695 - [devtools] Remove applySourceMap proxy in favor of an event.

This will help get rid of the proxy entirely.

Comment 5

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1801695 - [devtools] Remove Proxy on top of SourceMapLoader.

Comment 6

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1801695 - [devtools] Rename SourceMapService to SourceMapLoader.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b80085248912
[devtools] Use ChromeWorker for devtools frontend workers. r=bomsy
https://hg.mozilla.org/integration/autoland/rev/03a9f2939f63
[devtools] Store worker URL in their index.js module instead of callsite. r=bomsy
https://hg.mozilla.org/integration/autoland/rev/4d081dac3e31
[devtools] Use regular devtools loader to load SourceMap modules. r=bomsy
https://hg.mozilla.org/integration/autoland/rev/8435c181b8b9
[devtools] Remove applySourceMap proxy in favor of an event. r=bomsy
https://hg.mozilla.org/integration/autoland/rev/208656a729be
[devtools] Remove Proxy on top of SourceMapLoader. r=bomsy
https://hg.mozilla.org/integration/autoland/rev/136a6746e5db
[devtools] Rename SourceMapService to SourceMapLoader. r=bomsy

Comment 8

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/b80085248912
https://hg.mozilla.org/mozilla-central/rev/03a9f2939f63
https://hg.mozilla.org/mozilla-central/rev/4d081dac3e31
https://hg.mozilla.org/mozilla-central/rev/8435c181b8b9
https://hg.mozilla.org/mozilla-central/rev/208656a729be
https://hg.mozilla.org/mozilla-central/rev/136a6746e5db