Closed Bug 1801723 Opened 3 years ago Closed 3 years ago

PrivateBrowsingShortcut switch on installer does not prevent creation of the shortcut

Categories

(Firefox :: Installer, defect)

Firefox 107
defect

Tracking

()

RESOLVED WORKSFORME
Tracking Status
firefox-esr102 --- unaffected
firefox107 --- affected
firefox108 --- unaffected
firefox109 --- unaffected

People

(Reporter: haveylin, Unassigned)

Details

Steps to reproduce:

Tried running the regular installer from PS with the /PrivateBrowsingShortcut=false switch.

Actual results:

Firefox installed silently as expected because an argument was given, but the shortcut gets created anyway both in ProgramData during installation and in the user profile when a user runs Firefox.

Expected results:

The private browsing shortcut should not have been created.

The Bugbug bot thinks this bug should belong to the 'Firefox::Installer' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Component: Untriaged → Installer

I was able to reproduce this issue with Release 107, however I think this issue was already fixed in our latest builds because I cant reproduce this issue in our latest Beta build 108.0b4 or our latest Nightly build.

@jordan , can you try our latest beta build and see if the issue still occurs on your end ? you can find the build here :
https://ftp.mozilla.org/pub/firefox/candidates/108.0b4-candidates/build1/win64/en-US/

The command I used so the Private Browsing shortcut wouldnt be created:
"Firefox Setup 108.0b4.exe" /PrivateBrowsingShortcut=false

Severity: -- → S3
Status: UNCONFIRMED → NEW
Ever confirmed: true
Flags: needinfo?(haveylin)

That switch was implemented in 108 (https://bugzilla.mozilla.org/show_bug.cgi?id=1798743), so I'm not surprised it doesn't work in 107.

Thanks for taking a look here Rares.

(In reply to bhearsum@mozilla.com (:bhearsum) from comment #3)

That switch was implemented in 108 (https://bugzilla.mozilla.org/show_bug.cgi?id=1798743), so I'm not surprised it doesn't work in 107.

Apologies, I was going off of https://firefox-source-docs.mozilla.org/browser/installer/windows/installer/FullConfig.html which didn't mention which version it was introduced in. Thanks for letting me know.(In reply to Rares Doghi from comment #2)

Flags: needinfo?(haveylin)

(In reply to Jordan C. from comment #4)

Thanks for taking a look here Rares.

(In reply to bhearsum@mozilla.com (:bhearsum) from comment #3)

That switch was implemented in 108 (https://bugzilla.mozilla.org/show_bug.cgi?id=1798743), so I'm not surprised it doesn't work in 107.

Apologies, I was going off of https://firefox-source-docs.mozilla.org/browser/installer/windows/installer/FullConfig.html which didn't mention which version it was introduced in. Thanks for letting me know.(In reply to Rares Doghi from comment #2)

No worries, the report is appreciated regardless! I'll go ahead and resolve this though.

Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.