1801840 - alert dialog cover docked DevTools panel

Status: VERIFIED FIXED

(DevTools :: General, defect, P1)

Description

[David Balažic]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:107.0) Gecko/20100101 Firefox/107.0

Steps to reproduce:

• open a web page
• open Web Developer Tools with F12
• click on the web page on an element that opens an alert dialog (like alert('foo);)

(actually the alert is triggered by JavaScript code that executes on load of the page, not user click)

Actual results:

the devtools GUI at the bottom of the page is covered in gray overlay and can not be used

Expected results:

devtools usable

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'DevTools::General' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[David Balažic]

workaround: use devtools in a separate window

in that case it is not blocked by JavaScript alert dialogs

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

Simpler STR:

1. On this page, opens devtools, select the console
2. Execute alert("hi")

---

It looks like it was regressed in 107, I'll run mozregression to find what caused it

Comment 4

[Nicolas Chevobbe [:nchevobbe]]

Okay, mozregression gave me this push https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=12300304d39453250dfdaa8e249056659a20adbc&tochange=50f72898d7b8b88985dc5d7595007b426a46c93e

I suspected Bug 1791972 so I backed out https://hg.mozilla.org/mozilla-central/rev/fcfa74481179 , and I can confirm this fixes the issue

It's important to fix this issue as users might use alert to pause the application and do some work in DevTools

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1791972

:emilio, since you are the author of the regressor, bug 1791972, could you take a look? Also, could you set the severity field?

For more information, please visit auto_nag documentation.

Comment 6

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1801840 - Go back to using .browserStack rather than .browserContainer for tab dialog box. r=dao,Gijs,nchevobbe

This makes alert take the same area as the status panel, partially
backing out the regressing bug.

.browserStack is also relatively-positioned, so this works too. I think
I didn't realize this while writing bug 1791972 because the rule was in
a UA sheet (all <stack>s are relatively positioned, apparently).

This restores the behavior when devtools is toggled vertically. On
responsive mode this still covers the top toolbar, but that was the
pre-existing behavior. Could be fixed in a follow-up with some z-index
tweaking...

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c5387d626df7
Go back to using .browserStack rather than .browserContainer for tab dialog box. r=Gijs,nchevobbe

Comment 8

[Donal Meehan [:dmeehan]]

Please nominate this for beta and release uplift when ready

Comment 9

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/c5387d626df7

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox108 to wontfix.

For more information, please visit auto_nag documentation.

Comment 11

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9304739 [details]
Bug 1801840 - Go back to using .browserStack rather than .browserContainer for tab dialog box. r=dao,Gijs,nchevobbe

Beta/Release Uplift Approval Request

• User impact if declined: comment 0
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: comment 0
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): One-liner, effectively.
• String changes made/needed: none
• Is Android affected?: No

Comment 12

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9304739 [details]
Bug 1801840 - Go back to using .browserStack rather than .browserContainer for tab dialog box. r=dao,Gijs,nchevobbe

(see above)

I think it's safe for a ride-along.

Comment 13

[Donal Meehan [:dmeehan]]

Comment on attachment 9304739 [details]
Bug 1801840 - Go back to using .browserStack rather than .browserContainer for tab dialog box. r=dao,Gijs,nchevobbe

Approved for 108.0b7.

Comment 14

[Donal Meehan [:dmeehan]]

https://hg.mozilla.org/releases/mozilla-beta/rev/ee93bfddd271

Comment 15

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Reproduced the issue with Firefox 109.0a1 (20221122214324) on Windows 10x64. After following STR from comment 3 the devtools cannot be used.
The issue is verified fixed with Firefox 109.0a1 (2022-11-27) and 108.0b7 on Windows 10x64, macOS 10.15, and Ubuntu 20.04. The Web Developer Toolbox can be used as expected after executing an alert("hi") command inside the console.

Comment 16

[Donal Meehan [:dmeehan]]

Comment on attachment 9304739 [details]
Bug 1801840 - Go back to using .browserStack rather than .browserContainer for tab dialog box. r=dao,Gijs,nchevobbe

Approved for 107.0.1

Comment 17

[Donal Meehan [:dmeehan]]

https://hg.mozilla.org/releases/mozilla-release/rev/0615cd7117fa

Comment 18

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Verified fixed with Firefox 107.0.1 (20221128144904) on Windows 10x64, macOS 11, and Ubuntu 20.04. After the alert is triggered the dev tools can be used.