1801844 - Remove min-widget-size of some menu items.

Status: RESOLVED INCOMPLETE

(Core :: Widget: Win32, defect)

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1801844 - Remove some min-widget-size for various menuitem bits. r=cmartin,handyman

This fixes bug 1799460 for good. You can test this on Win10 with
browser.display.windows.non_native_menus=0 or HCM, but same applies to
Win7/8.

The front-end sets their own sizes anyways, and when the windows sizes
are less than the ones the front-end sets, we see that bug.

This is rather annoying because, even though it's fixable (we can fix
the intrinsic sizing code in the web to deal with this properly), it's
probably not worth fixing, as no web-exposed widget has a min-widget
size other than scrollbars and internal form control parts.

Removing this code altogether just works, since as I said before the
front-end sizes the menu parts anyways, so enforcing a given size in C++
is not necessary.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2be56c37e28d
Remove some min-widget-size for various menuitem bits. r=cmartin

Comment 3

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/2be56c37e28d

Comment 4

[Alin Ilea, Desktop Test Engineering]

Attachment: 2022-11-23_17h04_26.png

:Emilio, unfortunately, the issue doesn't seem to be fixed. I can reproduce it in both cases, with browser.display.windows.non_native_menus=0 or with high contrast enabled, using the latest Nightly build (20221123094429).

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Yes, bug 1801845 will remove all this and make them look non-native.

Comment 6

[Cristian Tuns]

Backed out for causing a regression

• Backout link

Comment 7

[Emilio Cobos Álvarez (:emilio)]

Let's do this altogether when I do bug 1801845.

Comment 8

[Iulian Moraru]

Backout merged to central: https://hg.mozilla.org/mozilla-central/rev/d348127a05b6