Closed Bug 1801852 Opened 2 years ago Closed 2 years ago

libwebrtc's copy of abseil causes way too many warnings about __has_trivial_destructor

Categories

(Core :: WebRTC, defect, P5)

defect

Tracking

()

RESOLVED FIXED
109 Branch
Tracking Status
firefox109 --- fixed

People

(Reporter: hsivonen, Assigned: mjf)

References

Details

Attachments

(1 file)

It looks like some aspect of bug 1779528 has regressed, and now when building locally on Linux x86_64 with mach-downloaded clang, there are so many warnings that reduce to
third_party/libwebrtc/third_party/abseil-cpp/absl/meta/type_traits.h:509:17: warning: builtin __has_trivial_assign is deprecated; use __is_trivially_assignable instead [-Wdeprecated-builtins
that it's hard to see actually relevant errors in the scrollback.

Mike, any thoughts on this?

Severity: -- → S4
Flags: needinfo?(mh+mozilla)
Priority: -- → P5

Apply the upstream fix?

Flags: needinfo?(mh+mozilla)

It would be really great to have this fixed.

Flags: needinfo?(mfroman)
Assignee: nobody → mfroman
Flags: needinfo?(mfroman)
Pushed by mfroman@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c00df1bd59a8 Cherry-pick abseil-cpp e61fc6d8 to fix deprecated builtins warnings on linux. r=ng
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 109 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: