1801897 - Avoid saving extra registers in CacheIRCompiler::emitCallNumberToString and MacroAssembler::initTypedArraySlots

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, task, P1)

Comment 1

[André Bargull [:anba]]

Attachment: Bug 1801897 - Part 1: Add an explicit assert to document the output is not a live register. r=iain!

In other code we're explicitly ignoring the output register when restoring
volatile registers, cf. CodeGeneratorShared::restoreLiveIgnore(). At least
document through an assertion why it's not necessary to exclude the output
register in visitNewArrayCallVM() and visitNewObjectVMCall().

Comment 2

[André Bargull [:anba]]

Attachment: Bug 1801897 - Part 2: Don't unnecessarily save the scratch float register across an ABI call. r=iain!

It shouldn't be necessary to save the scratch float register across an ABI call.

Depends on D162735

Comment 3

[André Bargull [:anba]]

Attachment: Bug 1801897 - Part 3: Only save live volatile registers across the ABI call in initTypedArraySlots. r=iain!

Instead of saving all volatile registers, only save the live volatile registers
when calling initTypedArraySlots(). And additionally don't save more temp
registers in initTypedArraySlots() itself.

Depends on D162736

Comment 4

[André Bargull [:anba]]

Attachment: Bug 1801897 - Part 4: Remove no longer needed comments. r=iain!

The instruction is now called LBinaryValueCache instead of just LBinaryCache.

Depends on D162737

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d37f559cfb32
Part 1: Add an explicit assert to document the output is not a live register. r=iain
https://hg.mozilla.org/integration/autoland/rev/c4d620ae9c71
Part 2: Don't unnecessarily save the scratch float register across an ABI call. r=iain
https://hg.mozilla.org/integration/autoland/rev/103df637eb59
Part 3: Only save live volatile registers across the ABI call in initTypedArraySlots. r=iain
https://hg.mozilla.org/integration/autoland/rev/465d2264fed5
Part 4: Remove no longer needed comments. r=iain

Comment 6

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/d37f559cfb32
https://hg.mozilla.org/mozilla-central/rev/c4d620ae9c71
https://hg.mozilla.org/mozilla-central/rev/103df637eb59
https://hg.mozilla.org/mozilla-central/rev/465d2264fed5