1801923 - 9.46% wikipedia ContentfulSpeedIndex (mean) (Windows) regression on Wed November 16 2022

Status: RESOLVED WONTFIX

(Core :: DOM: HTML Parser, defect)

Description

[Alex Finder]

Perfherder has detected a browsertime performance regression from push b77125a16db163b497e5a43dcf03c6fa43359005. As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

Ratio	Test	Platform	Options	Absolute values (old vs new)
9%	wikipedia ContentfulSpeedIndex (mean)	windows10-64-shippable-qr	cold fission webrender	902.10 -> 987.47

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests. Please follow our guide to handling regression bugs and let us know your plans within 3 business days, or the offending patch(es) may be backed out in accordance with our regression policy.

If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a sheriff to do that for you.

For more information on performance sheriffing please see our FAQ.

Comment 1

[Alex Finder]

(In reply to Alex Finder from comment #0)

Perfherder has detected a browsertime performance regression from push b77125a16db163b497e5a43dcf03c6fa43359005. As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

Ratio	Test	Platform	Options	Absolute values (old vs new)
9%	wikipedia ContentfulSpeedIndex (mean)	windows10-64-shippable-qr	cold fission webrender	902.10 -> 987.47

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests. Please follow our guide to handling regression bugs and let us know your plans within 3 business days, or the offending patch(es) may be backed out in accordance with our regression policy.

If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a sheriff to do that for you.

For more information on performance sheriffing please see our FAQ.

== Change summary for alert #36117 (as of Thu, 17 Nov 2022 14:25:37 GMT) ==

Regressions:

Ratio	Test	Platform	Options	Absolute values (old vs new)
33%	google-mail LastVisualChange	macosx1015-64-shippable-qr	fission warm webrender	1,426.67 -> 1,903.33
11%	wikipedia ContentfulSpeedIndex (geomean)	windows10-64-shippable-qr	cold fission webrender	876.53 -> 974.62
11%	wikipedia PerceptualSpeedIndex (geomean)	windows10-64-shippable-qr	cold fission webrender	880.94 -> 977.68
11%	wikipedia SpeedIndex (geomean)	windows10-64-shippable-qr	cold fission webrender	879.11 -> 975.68
10%	wikipedia ContentfulSpeedIndex (mean)	windows10-64-shippable-qr	cold fission webrender	887.82 -> 980.10
10%	wikipedia SpeedIndex (mean)	windows10-64-shippable-qr	cold fission webrender	889.79 -> 981.16
10%	wikipedia PerceptualSpeedIndex (mean)	windows10-64-shippable-qr	cold fission webrender	891.58 -> 983.10
9%	tumblr FirstVisualChange	windows10-64-shippable-qr	cold fission webrender	306.83 -> 333.08
8%	tumblr fcp	linux1804-64-shippable-qr	cold fission webrender	245.00 -> 264.25
5%	tumblr SpeedIndex	linux1804-64-shippable-qr	cold fission webrender	396.17 -> 415.00
3%	tumblr PerceptualSpeedIndex	linux1804-64-shippable-qr	cold fission webrender	461.71 -> 477.75

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)
36%	allrecipes loadtime	android-hw-a51-11-0-aarch64-shippable-qr	cold fission webrender	3,097.15 -> 1,992.21
33%	allrecipes LastVisualChange	android-hw-a51-11-0-aarch64-shippable-qr	cold fission webrender	7,169.54 -> 4,838.00
7%	wikipedia LastVisualChange	linux1804-64-shippable-qr	cold fission webrender	2,226.67 -> 2,073.33
6%	wikipedia LastVisualChange	linux1804-64-shippable-qr	bytecode-cached cold fission webrender	2,216.67 -> 2,086.67
5%	reddit ContentfulSpeedIndex	android-hw-a51-11-0-aarch64-shippable-qr	cold webrender	2,275.00 -> 2,151.17
...	...	...	...	...
4%	wikipedia LastVisualChange (mean)	linux1804-64-shippable-qr	cold fission webrender	2,203.62 -> 2,112.37

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=36117

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1800381

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Ah, finally the performance numbers come in :) Investigating

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

We also saw some other improvements like
https://bugzilla.mozilla.org/show_bug.cgi?id=1800347#c5

bug 1800381 and bug 1800347 landed together.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Smaug, what's the status of this bug for 109 as it goes to Beta next week?

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

This improved some things and regressed others, as what always happens with scheduling changes.
awfy didn't show changes though.

So, I'm not planning to back out the changes as of now, but since I'm in process of looking into parallelizing page load better (which the bugs were about), I want to still keep this open for awhile, in case I find something which would after all require backing the bugs out.

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1800381

Comment 8

[Alex Finder]

(In reply to Olli Pettay [:smaug][[e-mail]] from comment #4)

We also saw some other improvements like
https://bugzilla.mozilla.org/show_bug.cgi?id=1800347#c5

bug 1800381 and bug 1800347 landed together.

Hi Olly! Are there any updates on this regression bug ? I'm looking into closing the performance alert.

Comment 9

[Olli Pettay [:smaug][[e-mail]]]

Improvements were good enough.