Closed Bug 1801948 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 37089 - Fix presentation attribute mapping on SVGSMILElement

Categories

(Core :: SVG, task, P4)

Product:
Core
Component:
SVG
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
109 Branch
Tracking Flags:
Tracking Status
firefox109 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(Blocks 1 open bug,
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 37089 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/37089
Details from upstream follow.

Fredrik Söderquist <fs@opera.com> wrote:

Fix presentation attribute mapping on SVGSMILElement

Since only SVGSMILElement::IsPresentationAttribute() is implemented, if
SVGElement (or any other superclass) would trigger generation of the
presentation attribute property set, a 'fill' attribute would still end
up being mapped.

Implement SVGSMILElement::CollectStyleForPresentationAttribute as well
to ignore 'fill' completely.

Bug: 1375215
Change-Id: I2be7dd6167a91cfabd23a1ca27ba8dee547bdb01
Reviewed-on: https://chromium-review.googlesource.com/4047217
WPT-Export-Revision: 20451c7459e9489b66f259b09cfe6d5eeb5aa1e2

Component: web-platform-tests → SVG
Product: Testing → Core
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → INVALID
Status: RESOLVED → REOPENED
Resolution: INVALID → ---
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 4 tests and 59 subtests

Status Summary

Firefox

OK : 4
PASS: 103
FAIL: 105

Chrome

OK : 4
PASS: 197
FAIL: 14

Safari

OK : 4
PASS: 194
FAIL: 20

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

  • /svg/styling/presentation-attributes-irrelevant.html [wpt.fyi]
    • clip-path presentation attribute supported on an irrelevant element: FAIL
    • clip-rule presentation attribute supported on an irrelevant element: FAIL
    • color-interpolation-filters presentation attribute supported on an irrelevant element: FAIL
    • direction presentation attribute supported on an irrelevant element: FAIL
    • display presentation attribute supported on an irrelevant element: FAIL
    • dominant-baseline presentation attribute supported on an irrelevant element: FAIL
    • filter presentation attribute supported on an irrelevant element: FAIL
    • flood-color presentation attribute supported on an irrelevant element: FAIL
    • flood-opacity presentation attribute supported on an irrelevant element: FAIL
    • font-family presentation attribute supported on an irrelevant element: FAIL
    • font-size presentation attribute supported on an irrelevant element: FAIL
    • font-stretch presentation attribute supported on an irrelevant element: FAIL
    • font-style presentation attribute supported on an irrelevant element: FAIL
    • font-variant presentation attribute supported on an irrelevant element: FAIL
    • font-weight presentation attribute supported on an irrelevant element: FAIL
    • letter-spacing presentation attribute supported on an irrelevant element: FAIL
    • lighting-color presentation attribute supported on an irrelevant element: FAIL
    • marker-end presentation attribute supported on an irrelevant element: FAIL
    • marker-mid presentation attribute supported on an irrelevant element: FAIL
    • marker-start presentation attribute supported on an irrelevant element: FAIL
    • mask-type presentation attribute supported on an irrelevant element: FAIL
    • mask presentation attribute supported on an irrelevant element: FAIL
    • opacity presentation attribute supported on an irrelevant element: FAIL
    • overflow presentation attribute supported on an irrelevant element: FAIL
    • pointer-events presentation attribute supported on an irrelevant element: FAIL
    • stop-color presentation attribute supported on an irrelevant element: FAIL
    • stop-opacity presentation attribute supported on an irrelevant element: FAIL
    • text-anchor presentation attribute supported on an irrelevant element: FAIL
    • text-decoration presentation attribute supported on an irrelevant element: FAIL
    • transform-origin presentation attribute supported on an irrelevant element: FAIL
    • unicode-bidi presentation attribute supported on an irrelevant element: FAIL
    • vector-effect presentation attribute supported on an irrelevant element: FAIL
    • visibility presentation attribute supported on an irrelevant element: FAIL
    • word-spacing presentation attribute supported on an irrelevant element: FAIL
    • writing-mode presentation attribute supported on an irrelevant element: FAIL
  • /svg/styling/presentation-attributes-relevant.html [wpt.fyi]
    • color-interpolation presentation attribute supported on a relevant element: FAIL
  • /svg/styling/presentation-attributes-unknown.html [wpt.fyi]
    • clip-path presentation attribute supported on an unknown SVG element: FAIL
    • clip-rule presentation attribute supported on an unknown SVG element: FAIL
    • color presentation attribute supported on an unknown SVG element: FAIL
    • color-interpolation-filters presentation attribute supported on an unknown SVG element: FAIL
    • color-interpolation presentation attribute supported on an unknown SVG element: FAIL
    • cursor presentation attribute supported on an unknown SVG element: FAIL
    • direction presentation attribute supported on an unknown SVG element: FAIL
    • display presentation attribute supported on an unknown SVG element: FAIL
    • dominant-baseline presentation attribute supported on an unknown SVG element: FAIL
    • fill presentation attribute supported on an unknown SVG element: FAIL
    • fill-opacity presentation attribute supported on an unknown SVG element: FAIL
    • fill-rule presentation attribute supported on an unknown SVG element: FAIL
    • filter presentation attribute supported on an unknown SVG element: FAIL
    • flood-color presentation attribute supported on an unknown SVG element: FAIL
    • flood-opacity presentation attribute supported on an unknown SVG element: FAIL
    • font-family presentation attribute supported on an unknown SVG element: FAIL
    • font-size presentation attribute supported on an unknown SVG element: FAIL
    • font-stretch presentation attribute supported on an unknown SVG element: FAIL
    • font-style presentation attribute supported on an unknown SVG element: FAIL
    • font-variant presentation attribute supported on an unknown SVG element: FAIL
    • font-weight presentation attribute supported on an unknown SVG element: FAIL
    • image-rendering presentation attribute supported on an unknown SVG element: FAIL
    • letter-spacing presentation attribute supported on an unknown SVG element: FAIL
    • lighting-color presentation attribute supported on an unknown SVG element: FAIL
    • marker-end presentation attribute supported on an unknown SVG element: FAIL
    • marker-mid presentation attribute supported on an unknown SVG element: FAIL
    • marker-start presentation attribute supported on an unknown SVG element: FAIL
    • mask-type presentation attribute supported on an unknown SVG element: FAIL
    • mask presentation attribute supported on an unknown SVG element: FAIL
    • opacity presentation attribute supported on an unknown SVG element: FAIL
    • overflow presentation attribute supported on an unknown SVG element: FAIL
    • paint-order presentation attribute supported on an unknown SVG element: FAIL
    • pointer-events presentation attribute supported on an unknown SVG element: FAIL
    • shape-rendering presentation attribute supported on an unknown SVG element: FAIL
    • stop-color presentation attribute supported on an unknown SVG element: FAIL
    • stop-opacity presentation attribute supported on an unknown SVG element: FAIL
    • stroke presentation attribute supported on an unknown SVG element: FAIL
    • stroke-dasharray presentation attribute supported on an unknown SVG element: FAIL
    • stroke-dashoffset presentation attribute supported on an unknown SVG element: FAIL
    • stroke-linecap presentation attribute supported on an unknown SVG element: FAIL
    • stroke-linejoin presentation attribute supported on an unknown SVG element: FAIL
    • stroke-miterlimit presentation attribute supported on an unknown SVG element: FAIL
    • stroke-opacity presentation attribute supported on an unknown SVG element: FAIL
    • stroke-width presentation attribute supported on an unknown SVG element: FAIL
    • text-anchor presentation attribute supported on an unknown SVG element: FAIL
    • text-decoration presentation attribute supported on an unknown SVG element: FAIL
    • text-rendering presentation attribute supported on an unknown SVG element: FAIL
    • transform-origin presentation attribute supported on an unknown SVG element: FAIL
    • unicode-bidi presentation attribute supported on an unknown SVG element: FAIL
    • vector-effect presentation attribute supported on an unknown SVG element: FAIL
    • visibility presentation attribute supported on an unknown SVG element: FAIL
    • word-spacing presentation attribute supported on an unknown SVG element: FAIL
    • writing-mode presentation attribute supported on an unknown SVG element: FAIL

New Tests That Don't Pass

  • /svg/styling/presentation-attributes-irrelevant.html [wpt.fyi]
    • clip-path presentation attribute supported on an irrelevant element: FAIL (Chrome: PASS, Safari: PASS)
    • clip-rule presentation attribute supported on an irrelevant element: FAIL (Chrome: PASS, Safari: PASS)
    • color-interpolation-filters presentation attribute supported on an irrelevant element: FAIL (Chrome: PASS, Safari: PASS)
    • direction presentation attribute supported on an irrelevant element: FAIL (Chrome: PASS, Safari: PASS)
    • display presentation attribute supported on an irrelevant element: FAIL (Chrome: PASS, Safari: PASS)
    • dominant-baseline presentation attribute supported on an irrelevant element: FAIL (Chrome: PASS, Safari: PASS)
    • filter presentation attribute supported on an irrelevant element: FAIL (Chrome: PASS, Safari: PASS)
    • flood-color presentation attribute supported on an irrelevant element: FAIL (Chrome: PASS, Safari: PASS)
    • flood-opacity presentation attribute supported on an irrelevant element: FAIL (Chrome: PASS, Safari: PASS)
    • font-family presentation attribute supported on an irrelevant element: FAIL (Chrome: PASS, Safari: PASS)
    • font-size presentation attribute supported on an irrelevant element: FAIL (Chrome: PASS, Safari: PASS)
    • font-size-adjust presentation attribute supported on an irrelevant element: FAIL (Safari: PASS)
    • font-stretch presentation attribute supported on an irrelevant element: FAIL (Chrome: PASS, Safari: PASS)
    • font-style presentation attribute supported on an irrelevant element: FAIL (Chrome: PASS, Safari: PASS)
    • font-variant presentation attribute supported on an irrelevant element: FAIL (Chrome: PASS, Safari: PASS)
    • font-weight presentation attribute supported on an irrelevant element: FAIL (Chrome: PASS, Safari: PASS)
    • letter-spacing presentation attribute supported on an irrelevant element: FAIL (Chrome: PASS, Safari: PASS)
    • lighting-color presentation attribute supported on an irrelevant element: FAIL (Chrome: PASS, Safari: PASS)
    • marker-end presentation attribute supported on an irrelevant element: FAIL (Chrome: PASS, Safari: PASS)
    • marker-mid presentation attribute supported on an irrelevant element: FAIL (Chrome: PASS, Safari: PASS)
    • marker-start presentation attribute supported on an irrelevant element: FAIL (Chrome: PASS, Safari: PASS)
    • mask-type presentation attribute supported on an irrelevant element: FAIL (Chrome: PASS, Safari: PASS)
    • mask presentation attribute supported on an irrelevant element: FAIL (Chrome: PASS, Safari: PASS)
    • opacity presentation attribute supported on an irrelevant element: FAIL (Chrome: PASS, Safari: PASS)
    • overflow presentation attribute supported on an irrelevant element: FAIL (Chrome: PASS, Safari: PASS)
    • pointer-events presentation attribute supported on an irrelevant element: FAIL (Chrome: PASS, Safari: PASS)
    • stop-color presentation attribute supported on an irrelevant element: FAIL (Chrome: PASS, Safari: PASS)
    • stop-opacity presentation attribute supported on an irrelevant element: FAIL (Chrome: PASS, Safari: PASS)
    • text-anchor presentation attribute supported on an irrelevant element: FAIL (Chrome: PASS, Safari: PASS)
    • text-decoration presentation attribute supported on an irrelevant element: FAIL (Chrome: PASS, Safari: PASS)
    • text-overflow presentation attribute supported on an irrelevant element: FAIL (Chrome: FAIL, Safari: FAIL)
    • transform-origin presentation attribute supported on an irrelevant element: FAIL (Chrome: PASS, Safari: PASS)
    • unicode-bidi presentation attribute supported on an irrelevant element: FAIL (Chrome: PASS, Safari: PASS)
    • vector-effect presentation attribute supported on an irrelevant element: FAIL (Chrome: PASS, Safari: PASS)
    • visibility presentation attribute supported on an irrelevant element: FAIL (Chrome: PASS, Safari: PASS)
    • white-space presentation attribute supported on an irrelevant element: FAIL (Chrome: FAIL, Safari: FAIL)
    • word-spacing presentation attribute supported on an irrelevant element: FAIL (Chrome: PASS, Safari: PASS)
    • writing-mode presentation attribute supported on an irrelevant element: FAIL (Chrome: PASS, Safari: PASS)
  • /svg/styling/presentation-attributes-relevant.html [wpt.fyi]
    • color-interpolation presentation attribute supported on a relevant element: FAIL (Chrome: PASS, Safari: PASS)
    • text-overflow presentation attribute supported on a relevant element: FAIL (Chrome: FAIL, Safari: FAIL)
    • transform presentation attribute supported on a relevant element: FAIL (Chrome: PASS, Safari: FAIL)
    • white-space presentation attribute supported on a relevant element: FAIL (Chrome: FAIL, Safari: FAIL)
  • /svg/styling/presentation-attributes-special-cases.html [wpt.fyi]
    • x, y, width, and height presentation attributes supported on svg element: FAIL (Chrome: FAIL, Safari: PASS)
    • x, y, width, and height presentation attributes supported on symbol element: FAIL (Chrome: FAIL, Safari: PASS)
    • x, y, width, and height presentation attributes supported on use element: FAIL (Chrome: FAIL, Safari: PASS)
    • transform presentation attribute supported on g: FAIL (Chrome: PASS, Safari: FAIL)
    • patternTransform presentation attribute supported on pattern: FAIL (Chrome: PASS, Safari: FAIL)
    • patternTransform presentation attribute supported on linearGradient: FAIL (Chrome: PASS, Safari: FAIL)
    • patternTransform presentation attribute supported on radialGradient: FAIL (Chrome: PASS, Safari: FAIL)
  • /svg/styling/presentation-attributes-unknown.html [wpt.fyi]
    • clip-path presentation attribute supported on an unknown SVG element: FAIL (Chrome: PASS, Safari: PASS)
    • clip-rule presentation attribute supported on an unknown SVG element: FAIL (Chrome: PASS, Safari: PASS)
    • color presentation attribute supported on an unknown SVG element: FAIL (Chrome: PASS, Safari: PASS)
    • color-interpolation-filters presentation attribute supported on an unknown SVG element: FAIL (Chrome: PASS, Safari: PASS)
    • color-interpolation presentation attribute supported on an unknown SVG element: FAIL (Chrome: PASS, Safari: PASS)
    • cursor presentation attribute supported on an unknown SVG element: FAIL (Chrome: PASS, Safari: PASS)
    • direction presentation attribute supported on an unknown SVG element: FAIL (Chrome: PASS, Safari: PASS)
    • display presentation attribute supported on an unknown SVG element: FAIL (Chrome: PASS, Safari: PASS)
    • dominant-baseline presentation attribute supported on an unknown SVG element: FAIL (Chrome: PASS, Safari: PASS)
    • fill presentation attribute supported on an unknown SVG element: FAIL (Chrome: PASS, Safari: PASS)
    • fill-opacity presentation attribute supported on an unknown SVG element: FAIL (Chrome: PASS, Safari: PASS)
    • fill-rule presentation attribute supported on an unknown SVG element: FAIL (Chrome: PASS, Safari: PASS)
    • filter presentation attribute supported on an unknown SVG element: FAIL (Chrome: PASS, Safari: PASS)
    • flood-color presentation attribute supported on an unknown SVG element: FAIL (Chrome: PASS, Safari: PASS)
    • flood-opacity presentation attribute supported on an unknown SVG element: FAIL (Chrome: PASS, Safari: PASS)
    • font-family presentation attribute supported on an unknown SVG element: FAIL (Chrome: PASS, Safari: PASS)
    • font-size presentation attribute supported on an unknown SVG element: FAIL (Chrome: PASS, Safari: PASS)
    • font-size-adjust presentation attribute supported on an unknown SVG element: FAIL (Safari: PASS)
    • font-stretch presentation attribute supported on an unknown SVG element: FAIL (Chrome: PASS, Safari: PASS)
    • font-style presentation attribute supported on an unknown SVG element: FAIL (Chrome: PASS, Safari: PASS)
    • font-variant presentation attribute supported on an unknown SVG element: FAIL (Chrome: PASS, Safari: PASS)
    • font-weight presentation attribute supported on an unknown SVG element: FAIL (Chrome: PASS, Safari: PASS)
    • image-rendering presentation attribute supported on an unknown SVG element: FAIL (Chrome: PASS, Safari: PASS)
    • letter-spacing presentation attribute supported on an unknown SVG element: FAIL (Chrome: PASS, Safari: PASS)
    • lighting-color presentation attribute supported on an unknown SVG element: FAIL (Chrome: PASS, Safari: PASS)
    • marker-end presentation attribute supported on an unknown SVG element: FAIL (Chrome: PASS, Safari: PASS)
    • marker-mid presentation attribute supported on an unknown SVG element: FAIL (Chrome: PASS, Safari: PASS)
    • marker-start presentation attribute supported on an unknown SVG element: FAIL (Chrome: PASS, Safari: PASS)
    • mask-type presentation attribute supported on an unknown SVG element: FAIL (Chrome: PASS, Safari: PASS)
    • mask presentation attribute supported on an unknown SVG element: FAIL (Chrome: PASS, Safari: PASS)
    • opacity presentation attribute supported on an unknown SVG element: FAIL (Chrome: PASS, Safari: PASS)
    • overflow presentation attribute supported on an unknown SVG element: FAIL (Chrome: PASS, Safari: PASS)
    • paint-order presentation attribute supported on an unknown SVG element: FAIL (Chrome: PASS, Safari: PASS)
    • pointer-events presentation attribute supported on an unknown SVG element: FAIL (Chrome: PASS, Safari: PASS)
    • shape-rendering presentation attribute supported on an unknown SVG element: FAIL (Chrome: PASS, Safari: PASS)
    • stop-color presentation attribute supported on an unknown SVG element: FAIL (Chrome: PASS, Safari: PASS)
    • stop-opacity presentation attribute supported on an unknown SVG element: FAIL (Chrome: PASS, Safari: PASS)
    • stroke presentation attribute supported on an unknown SVG element: FAIL (Chrome: PASS, Safari: PASS)
    • stroke-dasharray presentation attribute supported on an unknown SVG element: FAIL (Chrome: PASS, Safari: PASS)
    • stroke-dashoffset presentation attribute supported on an unknown SVG element: FAIL (Chrome: PASS, Safari: PASS)
    • stroke-linecap presentation attribute supported on an unknown SVG element: FAIL (Chrome: PASS, Safari: PASS)
    • stroke-linejoin presentation attribute supported on an unknown SVG element: FAIL (Chrome: PASS, Safari: PASS)
    • stroke-miterlimit presentation attribute supported on an unknown SVG element: FAIL (Chrome: PASS, Safari: PASS)
    • stroke-opacity presentation attribute supported on an unknown SVG element: FAIL (Chrome: PASS, Safari: PASS)
    • stroke-width presentation attribute supported on an unknown SVG element: FAIL (Chrome: PASS, Safari: PASS)
    • text-anchor presentation attribute supported on an unknown SVG element: FAIL (Chrome: PASS, Safari: PASS)
    • text-decoration presentation attribute supported on an unknown SVG element: FAIL (Chrome: PASS, Safari: PASS)
    • text-overflow presentation attribute supported on an unknown SVG element: FAIL (Chrome: FAIL, Safari: FAIL)
    • text-rendering presentation attribute supported on an unknown SVG element: FAIL (Chrome: PASS, Safari: PASS)
    • transform-origin presentation attribute supported on an unknown SVG element: FAIL (Chrome: PASS, Safari: PASS)
    • unicode-bidi presentation attribute supported on an unknown SVG element: FAIL (Chrome: PASS, Safari: PASS)
    • vector-effect presentation attribute supported on an unknown SVG element: FAIL (Chrome: PASS, Safari: PASS)
    • visibility presentation attribute supported on an unknown SVG element: FAIL (Chrome: PASS, Safari: PASS)
    • white-space presentation attribute supported on an unknown SVG element: FAIL (Chrome: FAIL, Safari: FAIL)
    • word-spacing presentation attribute supported on an unknown SVG element: FAIL (Chrome: PASS, Safari: PASS)
    • writing-mode presentation attribute supported on an unknown SVG element: FAIL (Chrome: PASS, Safari: PASS)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a04fd73fb9fc [wpt PR 37089] - Fix presentation attribute mapping on SVGSMILElement, a=testonly

https://hg.mozilla.org/mozilla-central/rev/a04fd73fb9fc

Status: REOPENED → RESOLVED
Closed: 2 years ago → 2 years ago
status-firefox109: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 109 Branch
You need to log in before you can comment on or make changes to this bug.