1801954 - Should be able to drive region selection from keyboard in screenshots component

Status: RESOLVED FIXED

(Firefox :: Screenshots, defect, P3)

Description

[Niklas Baumgardner [:niklas]]

We should be able to create and edit a region from the keyboard using the screenshots component

Comment 1

[Niklas Baumgardner [:niklas]]

Attachment: Bug 1801954 - Make screenshots selection movable via the keyboard. r=sfoster

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/87051213c0bc
Make screenshots selection movable via the keyboard. r=sfoster,desktop-theme-reviewers

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b96506a6d950
Attempt to fix non-unified build bustage on SetDefaultBrowser.h. r=glandium

Comment 4

[Cosmin Sabou [:CosminS]]

The patch in comment 3 landed with wrong bug number, it has been backed out here: https://hg.mozilla.org/integration/autoland/rev/e6ae1cdc891e0036686f7795cdd46ef290c727ce

Comment 5

[Serban Stanca [:SerbanS]]

Backed out for causing mochitests failures in browser_overlay_keyboard_test.js and on OSX.

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | browser/components/screenshots/tests/browser/browser_overlay_keyboard_test.js | Left dimension is correct - 101 == 1265 - got 101, expected 1265 (operator ==)

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c8974c34f991
Make screenshots selection movable via the keyboard. r=sfoster,desktop-theme-reviewers

Comment 7

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/c8974c34f991