Closed Bug 1801954 Opened 1 year ago Closed 3 months ago

Should be able to drive region selection from keyboard in screenshots component

Categories

(Firefox :: Screenshots, defect, P3)

defect

Tracking

()

RESOLVED FIXED
122 Branch
Tracking Status
firefox122 --- fixed

People

(Reporter: niklas, Assigned: niklas, NeedInfo)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

We should be able to create and edit a region from the keyboard using the screenshots component

Blocks: 1796205
Severity: -- → S3
Priority: -- → P3
Assignee: nobody → nbaumgardner
Status: NEW → ASSIGNED
Pushed by nbaumgardner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/87051213c0bc
Make screenshots selection movable via the keyboard. r=sfoster,desktop-theme-reviewers
Pushed by csabou@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b96506a6d950
Attempt to fix non-unified build bustage on SetDefaultBrowser.h. r=glandium

The patch in comment 3 landed with wrong bug number, it has been backed out here: https://hg.mozilla.org/integration/autoland/rev/e6ae1cdc891e0036686f7795cdd46ef290c727ce

Backed out for causing mochitests failures in browser_overlay_keyboard_test.js and on OSX.

  • Backout link
  • Push with failures
  • Failure Log
  • Failure line: TEST-UNEXPECTED-FAIL | browser/components/screenshots/tests/browser/browser_overlay_keyboard_test.js | Left dimension is correct - 101 == 1265 - got 101, expected 1265 (operator ==)
Flags: needinfo?(nbaumgardner)
Pushed by nbaumgardner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c8974c34f991
Make screenshots selection movable via the keyboard. r=sfoster,desktop-theme-reviewers
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → 122 Branch
You need to log in before you can comment on or make changes to this bug.