1802134 - [Experiment] The users can be enrolled in the “Onboarding Welcome Video Experiment” even if they prefer reduced motion

Status: VERIFIED FIXED

(Firefox :: Messaging System, defect, P1)

Description

[Simona Rosu [:srosu], Ecosystem QA]

Attachment: OnboardingVideoExp_ReducedMotion.gif

[Affected versions]:

• Firefox Beta 108.0b5 - Build ID: 20221122190120

[Affected Platforms]:

• Windows 10 x64
• Windows 11 x64

[Prerequisites]:

• Have the Firefox Beta 108.0b5 browser installed.
• Have this user.js saved on your computer.
• Have the “Show animations on Windows” set to Off in OS settings.

[Steps to reproduce]:

1. Open the browser using the -p --first-startup and create a new profile.
2. Copy and paste the user.js file from prerequisites on the Profile Folder.
3. Open the Firefox profile from prerequisites.
4. Navigate to the “about:studies” page.
5. Observe the listed studies.

[Expected result]:

• The “Onboarding Welcome Video Experiment” experiment is not displayed on the “about:studies” page.

[Actual result]:

• The “Onboarding Welcome Video Experiment” experiment is displayed on the “about:studies” page.

[Notes]:

• The “userPrefersReducedMotion” is recognized as true in the ASRouter devtool.
• Attached is a screen recording of the issue.

Comment 1

[Punam Dahiya [:pdahiya]]

Should not be a blocker for Fx108 but will be good to investigate and fix for Fx109 experiment autoplay true treatment branch

Comment 2

[hanna A]

Attachment: Bug 1802134 - [Experiment] The users can be enrolled in the “Onboarding Welcome Video Experiment” even if they prefer reduced motion r=mviar

Comment 3

[hanna A]

Thanks, we had some trouble enrolling to the experiment because the sampling id provided in the repro steps was not working, but using the id 'a0' we were able to enroll.This was the output:

RSLoader: Testing targeting expression: (browserSettings.update.channel == "beta") && ((experiment.slug in activeExperiments) || (((isFirstStartup && !('trailhead.firstrun.didSeeAboutWelcome'|preferenceValue)) && os.windowsBuildNumber >= 18362 && (currentDate|date - profileAgeCreated|date) / 3600000 <= 24 && !isDefaultBrowser && !userPrefersReducedMotion) && (version|versionCompare('108.!') >= 0) && (locale in ['en-CA', 'en-GB', 'en-US']))) RemoteSettingsExperimentLoader.jsm:183

RSLoader: [experiment] onboarding-welcome-video-experiment matched RemoteSettingsExperimentLoader.jsm:356
ExperimentManager: Client was not enrolled because of the bucket sampling ExperimentManager.jsm:176

The issue was that in first startup, targeting was being evaluated before the browser was available. userPrefersReducedMotion was undefined. I've addressed the issue in the patch.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/08b706510522
[Experiment] The users can be enrolled in the “Onboarding Welcome Video Experiment” even if they prefer reduced motion r=mviar

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/08b706510522

Comment 6

[Simona Rosu [:srosu], Ecosystem QA]

I‘ve verified this issue using the latest Firefox Nightly 109.0a1 (Build ID: 20221208094253) on Windows 10 x64, and Windows 11 x64.

• The users cannot be enrolled in the “Onboarding Welcome Video” experiment if they prefer reduced motion.

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:halemu, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox108 to wontfix.

For more information, please visit auto_nag documentation.

Comment 8

[hanna A]

We don't need to uplift it to 108, thanks!