Closed Bug 1802137 Opened 6 months ago Closed 2 months ago

Enhance support for serialization and deserialization of platform objects of type Node for ShadowRoot

Categories

(Remote Protocol :: WebDriver BiDi, task, P1)

Product:
Remote Protocol
Component:
WebDriver BiDi
Type:
task
Points:
5

Tracking

(firefox113 fixed)

Status:
RESOLVED FIXED
Milestone:
113 Branch
Tracking Flags:
Tracking Status
firefox113 --- fixed

People

(Reporter: whimboo, Assigned: Sasha)

References

(Blocks 1 open bug,
URL
)

Details

(Whiteboard: [webdriver:m6], [wptsync upstream] [webdriver:relnote])

Attachments

(2 files)

Bug 1802137 - [bidi] Enhance support for serialization and deserialization of platform objects of type Node for ShadowRoot.
48 bytes, text/x-phabricator-request
Details | Review
Bug 1802137 - [wdspec] Add tests for serialization and deserialization of platform objects of type Node for ShadowRoot.
48 bytes, text/x-phabricator-request
Details | Review

With the work on bug 1770731 support for platform objects of type Node gets added. The one thing which is missing is all around Shadow DOM support. The following should cover it:

  • shadowRoot field of a DOM element
  • serialization of a ShadowRoot node
  • serialization of elements from within a Shadow DOM

Similar use cases should apply for deserialization.

Points: --- → 5
Priority: -- → P2
Whiteboard: [webdriver:backlog]
Summary: Enhance Shadow DOM support for serialization of platform objects of type Node → Enhance support for serialization and deserialization of platform objects of type Node for ShadowRoot
No longer blocks: 1791964

We should wait for bug 1770733 being fixed first to make sure that the sharedId is correctly set for the serialization of ShadowRoot objects.

Depends on: 1770733

Adding as tentative bug for our M6 milestone.

Priority: P2 → P1
Whiteboard: [webdriver:backlog] → [webdriver:m6]
Whiteboard: [webdriver:m6] → [webdriver:m6:blocked]
Whiteboard: [webdriver:m6:blocked] → [webdriver:m6]
Assignee: nobody → aborovova
Status: NEW → ASSIGNED
Whiteboard: [webdriver:m6] → [webdriver:m6][webdriver:triage]

For now, we just will serialize sharedId for shadow root, serialization of shadow root children will be addressed in the follow-up.

Whiteboard: [webdriver:m6][webdriver:triage] → [webdriver:m6]
Pushed by aborovova@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8a30cdba42d0
[bidi] Enhance support for serialization and deserialization of platform objects of type Node for ShadowRoot. r=webdriver-reviewers,whimboo
https://hg.mozilla.org/integration/autoland/rev/e46b77809f60
[wdspec] Add tests for serialization and deserialization of platform objects of type Node for ShadowRoot. r=webdriver-reviewers,jdescottes,whimboo
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/39281 for changes under testing/web-platform/tests
Whiteboard: [webdriver:m6] → [webdriver:m6], [wptsync upstream]

https://hg.mozilla.org/mozilla-central/rev/8a30cdba42d0
https://hg.mozilla.org/mozilla-central/rev/e46b77809f60

Status: ASSIGNED → RESOLVED
Closed: 2 months ago
status-firefox113: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 113 Branch
Upstream PR merged by moz-wptsync-bot
Whiteboard: [webdriver:m6], [wptsync upstream] → [webdriver:m6], [wptsync upstream] [webdriver:relnote]
You need to log in before you can comment on or make changes to this bug.