1802192 - Re-enable macOS fullscreen tests

Status: RESOLVED INVALID

(Core :: Widget: Cocoa, defect, P3)

Description

[Brad Werth [:bradwerth]]

Bug 1631735 disabled some macOS fullscreen tests that failed due to changes in our use of the macOS fullscreen API. The problems in these tests do not seem to appear during interactive fullscreen browser usage, but we still want the test coverage, so these tests and/or the code need to be fixed. The tests need to work with both true and false values of the full-screen-api.macos-native-full-screen pref.

Comment 1

[Brad Werth [:bradwerth]]

Re-enabling these tests will involve some combination of...

1. Defining a new event to be fired when the fullscreen transition is complete. Most tests are waiting for the sizemode event, which is fired at the beginning of the transition. Presently, there is no event sent at the end of the transition.
2. Make nsCocoaWindow respond to requests to minimize the window during a transition, similar to how it handles requests to undo the fullscreen state or to set the window's visibility during a transition.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Hi Brad, with the change on bug 1631735 we basically have a regression for WebDriver when users want to manipulate the window after leaving fullscreen mode. We don't know how many folks would be affected by that, so it raises a question for us when we can get these tests working again for headfull mode. Do you have an estimate when this bug can / will be fixed? Could it happen for the 110 release? Thanks.

Comment 3

[Brad Werth [:bradwerth]]

I hope to revise and re-land Bug 1631735 with no impact to Webdriver tests, which will allow this Bug to be closed as INVALID.

Comment 4

[Brad Werth [:bradwerth]]

After many changes, Bug 1631735 landed without disabling any existing tests. No work to do here.