1802265 - Pocket newtab sponsored topsites should use title instead as sponsor

Status: VERIFIED FIXED

(Firefox :: New Tab Page, enhancement)

Description

[Scott [:thecount] Downe]

Right now sponsored topsites from Pocket are using the sponsor label as the topsite title.

We should update this to be title if available, and fall back to sponsor label if there is no title.

Comment 1

[Scott [:thecount] Downe]

[Tracking Requested - why for this release]: Should be a 1 line fix, and would impact an upcoming experiment.

Comment 2

[Scott [:thecount] Downe]

Attachment: Bug 1802265 - Pocket newtab topsite spoc use title instead of sponsor.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/898e7b642333
Pocket newtab topsite spoc use title instead of sponsor. r=nanj

Comment 4

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/898e7b642333

Comment 5

[Scott [:thecount] Downe]

Comment on attachment 9305057 [details]
Bug 1802265 - Pocket newtab topsite spoc use title instead of sponsor.

Beta/Release Uplift Approval Request

• User impact if declined: Impact to an experiment
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Testing should be regression testing for sponsored topsite title is still visible.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): It is a simple 2 line change.
• String changes made/needed: None
• Is Android affected?: No

Comment 6

[Dianna Smith [:diannaS]]

Comment on attachment 9305057 [details]
Bug 1802265 - Pocket newtab topsite spoc use title instead of sponsor.

Approved for 108.0b7

Comment 7

[Dianna Smith [:diannaS]]

https://hg.mozilla.org/releases/mozilla-beta/rev/b6695d1fe8d2

Comment 8

[Cosmin Muntean [:cmuntean], Ecosystem QA]

I have verified this issue on the latest Nightly 109.0a1 (Build ID: 20221129084032) and the latest Beta 108.0b7 (Build ID: 20221127190117) on Windows 10 x64, macOS 12.4 and Linux Mint 20.

• The Sponsored tiles via Pocket have the title correctly displayed.