1802320 - Field Alignment issue in `rust-bindgen` not being caught by `mach rusttests`

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[Adam Vandolder [:avandolder]]

When removing nsIRadioGroupContainer as a superclass of ShadowRoot, a C++ layout optimization is triggered which bindgen is unable to handle properly (see https://github.com/rust-lang/rust-bindgen/issues/380). mach rusttests is currently unable to detect this alignment failure between the C++ class and the generated Rust struct.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1802320 - Green up and re-enable style system layout tests. r=#style,#layout

It's unclear to me when they were disabled, but we do want to enable
these as otherwise there's no way to catch bindgen issues that can end
up in subtle bugs at best, or memory corruption at worst.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

https://treeherder.mozilla.org/jobs?repo=try&revision=6ad13b6b39681d44f9f2479c791c01e8a0659467

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/836daf423ead
Green up and re-enable style system layout tests. r=boris

Comment 4

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/836daf423ead

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/86366a8c0c63
Try to green up tier 2 i686-linux tests.

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/86366a8c0c63

Comment 8

[Intermittent Failures Robot]

4 failures in 3888 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-central: 4

Platform and build breakdown:

• linux32: 4
  • opt: 2
  • debug: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1802320&startday=2022-11-21&endday=2022-11-27&tree=all

Comment 9

[Iulian Moraru]

This is still happening: https://treeherder.mozilla.org/jobs?repo=mozilla-central&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception%2Crunnable&searchStr=linux%2Cdebug%2Cbuild-linux-rusttests%2Fdebug%2Cbr&group_state=expanded&selectedTaskRun=SBEViXnVTfabmJ8uQOvZrw.0&fromchange=8b092cca2cab001ed8d13fc83d17bdba39cffe0d&tochange=e46a721b2af4ee095d4f554a9e894efc1050d6e1

Hi Emilio! Can you please take another look at this? Should we file a new bug or reopen this one?
Thank you!

Comment 10

[Emilio Cobos Álvarez (:emilio)]

I filed bug 1803350 for the remaining issue.

Comment 11

[Intermittent Failures Robot]

10 failures in 3938 pushes (0.003 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-central: 10

Platform and build breakdown:

• linux32: 10
  • debug: 10

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1802320&startday=2022-11-28&endday=2022-12-04&tree=all