1802325 - Should have automated tests for Windows 10+ SSO code

Status: NEW

(Core :: Networking, task, P3)

Description

[:Gijs (out for now; he/him)]

The code in bug 1695693 is indicated as having no coverage in searchfox (see e.g. https://searchfox.org/mozilla-central/rev/5a49163b7012ded5fa1c4da5aa4f8d3f7c85a5e7/netwerk/protocol/http/nsHttpChannel.cpp#419 and the AddWindowsSSO function referenced there). There don't appear to be automated tests in https://phabricator.services.mozilla.com/D114540 and https://searchfox.org/mozilla-central/search?q=windows-sso.enabled&path=test&case=false&regexp=false shows no hits other than the test that checks that enabling the policy flips the pref - we don't test making any requests with that pref set, or verify the headers that are set.

We should fix that so we don't break this going forward.

Comment 1

[Mike Kaply [:mkaply]]

We couldn't come up with any way to test this. It requires that a Windows login be enabled on the build machine to verify the API has produced the correct results.

Comment 2

[Valentin Gosu [:valentin] (he/him)]

Presumably we could add a mock for the windows methods like we do here