1802363 - [KDE] Popups sometimes flickered when hovering over other buttons followed by Firefox 106.0a1-109.0a1 on Wayland freezing

Status: RESOLVED DUPLICATE of bug 1772073

(Core :: Widget: Gtk, defect, P2)

Description

[Matt Fagnani]

Attachment: firefox-109.0a1-2022-11-24-popup-flickering-then-freeze-1.mp4

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:109.0) Gecko/20100101 Firefox/109.0

Steps to reproduce:

I started Firefox 109.0a1 20221124093251 on Wayland with WebRender compositing in Plasma 5.26.3 in a Fedora 37 KDE Plasma installation. I loaded various https sites. I clicked on the Extended Tracking Protection, Site Information, DRM settings buttons in the address bar or Pocket, View History... buttons in the toolbar. I moved the cursor over buttons in the address bar, toolbar, or the navigation toolbar with the Go back one page, Reload, Home page buttons to the left of the address bar other than that of the currently shown popup and hovered over it for at least a second so that tooltips would normally be shown.

Actual results:

The popups sometimes flickered briefly to their left when hovering over other buttons. The tooltips of the buttons the cursor was over weren't shown when the popups flickered, but they were shown when the flickering didn't happen. When I selected the Pocket button in the toolbar and then hovered the cursor over the buttons to its right, Firefox froze two different times. The interface turned grey and Firefox Nightly (Not Responding) was shown in the title bar. I'm attaching a recording of the popup flickering occurring when the Extended Tracking Protection and Pocket popups were shown and I moved the cursor over other buttons so that tooltips would be shown. Firefox froze while the Pocket popup was shown and I moved the cursor over the buttons to its right in the toolbar. The interface turned grey and Firefox Nightly (Not Responding) was shown at the top of the window after I stopped the recording.

I think I saw this popup flickering problem first with 109.0a1 20221123213526 on Wayland, but it might started earlier than that. I'll try to bisect this problem. I didn't see this problem with Firefox 109.0a1 20221124093251 on XWayland in the same environment, so this might be specific to Wayland.

Expected results:

The popups wouldn't flicker when hovering the cursor over other buttons. Firefox wouldn't freeze when doing so.

Comment 1

[Martin Stránský [:stransky] (ni? me) (PTO, back on Feb 17)]

Can you please try to test under nested mutter?
https://fedoraproject.org/wiki/How_to_debug_Firefox_problems#Testing_different_Wayland_compositor

It may me related to some optimization we did to popup rendering to avoid flickering of xdg_popups.

Comment 2

[Martin Stránský [:stransky] (ni? me) (PTO, back on Feb 17)]

It's definitely Wayland related.

Comment 3

[Matt Fagnani]

(In reply to Martin Stránský [:stransky] (ni? me) from comment #1)

Can you please try to test under nested mutter?
https://fedoraproject.org/wiki/How_to_debug_Firefox_problems#Testing_different_Wayland_compositor

It may me related to some optimization we did to popup rendering to avoid flickering of xdg_popups.

The flickering popups and freezing problem didn't happen with 109.0a1 20221124093251 on Wayland under nested mutter in Plasma or in GNOME 43.1 in Fedora 37, so the problem might be specific to Plasma. I reproduced the flickering and freezing problem with Fedora's build of 107.0 in Plasma 5.26.3 in Fedora 37. The problem might have been introduced in the 107 branch or earlier. This problem might be more time consuming to bisect than I thought. Thanks.

Comment 4

[Matt Fagnani]

106.0a1 2022-9-1 didn't have this problem while 106.0a1 2022-9-15 was affected. I ran mozregression --good 2022-9-1 --bad 2022-9-15 --persist /tmp/mozregression The final pushlog showed two revisions for Bug 1785185 involving popups on Wayland.

f29b50d37b8b44da60afb52885a3dfecd96ecfba stransky — Bug 1785185 [Wayland] Remove useRelativeCoordinates r=emilio
9ed132468bfa67ffbd09c06c251012f87b897701 stransky — Bug 1785185 [Wayland] Set popup type according to moving method r=emilio

23:32.57 INFO: Narrowed integration regression window from [6676e54c, f29b50d3] (4 builds) to [3f26214c, f29b50d3] (2 builds) (~1 steps left)
23:32.57 INFO: No more integration revisions, bisection finished.
23:32.57 INFO: Last good revision: 3f26214c64a46e20926bdb4ed277ab57b0d2bd61
23:32.57 INFO: First bad revision: f29b50d37b8b44da60afb52885a3dfecd96ecfba
23:32.57 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=3f26214c64a46e20926bdb4ed277ab57b0d2bd61&tochange=f29b50d37b8b44da60afb52885a3dfecd96ecfba

Bug 1789050 involved flickering of bookmarks menus to the left of where they were shown, and it was also regressed by Bug 1785185. Bug 1789050 was fixed in 106.0a1 (2022-09-06) 20220906213903.

Comment 5

[Martin Stránský [:stransky] (ni? me) (PTO, back on Feb 17)]

This is a bug in KDE Wayland compositor. We create wl_subsurface popup type and then open new tooltip (wl_subsurface) attached to it.
The flickering popup stays still from Firefox POV, we just attach/detach tooltip to it. Perhaps it's a bit surprising to use wl_subsurface for tooltips?
Vlad, something you want to look at?

Comment 6

[Vlad Zahorodnii [:zzag]]

It looks like https://bugzilla.mozilla.org/show_bug.cgi?id=1772073

While kwin should add subsurfaces when the parent is committed, firefox should not nuke other subsurfaces when another popup is mapped.