1802364 - Convert ETP breakage report links to toolbarbuttons in ETP panel

Status: RESOLVED FIXED

(Firefox :: Protections UI, enhancement, P5)

Description

[Mark Striemer [:mstriemer]]

Attachment: image.png

The link to open the report panel when ETP is off looks like it will open a tab or something, but it slides over to a new panel. It should probably use a .subviewbutton.subviewbutton-nav instead of a link so it's clearer that it will open the form in the panel.

Comment 1

[Hanna Jones [:hjones]]

Attachment: Panel with toolbarbutton shown

To get started on this bug you'll probably want to disable popup autohide via the browser multiprocess toolbox. You can find info on how to do that (as well as how to enable the toolbox) here. You should then be able to inspect the UI to find the relevant lines in the code.

The goal is to switch from using a link to a button that looks like some of the other buttons in this panel - for example the "Cross-Site Tracking Cookies" button (or any similar button with the ">" chevron indicating that the panel will slide over when the user clicks it - see attached screenshot). There may also be some CSS that needs to be removed to prevent this text from getting styled like a link. The relevant tests can be found in browser/base/content/test/protectionsUI/browser_protectionsUI_report_breakage.js.

Comment 2

[Ganna]

Attachment: Bug 1802364 - Convert ETP breakage report links to toolbarbuttons in ETP panel. r=hjones

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ac00a0a0824d
Convert ETP breakage report links to toolbarbuttons in ETP panel. r=hjones,desktop-theme-reviewers,anti-tracking-reviewers,Itiel,pbz

Comment 4

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/ac00a0a0824d