1802551 - Remove osfile.jsm usage from toolkit/components/telemetry/app/TelemetryStorage.jsm

Status: RESOLVED FIXED

(Toolkit Graveyard :: OS.File, task, P1)

Description

[Beth Rennie [:beth] (she/her)]

https://searchfox.org/mozilla-central/search?q=osfile.jsm&path=%5Etoolkit%2Fcomponents%2Ftelemetry%2Fapp%2FTelemetryStorage&case=false&regexp=false

Comment 4

[Beth Rennie [:beth] (she/her)]

Attachment: Bug 1802551 - Port osfile.jsm usage to IOUtils in TelemetryStorage.jsm r?chutten

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5fb1ba731fbc
Port osfile.jsm usage to IOUtils in TelemetryStorage.jsm r=chutten

Comment 6

[Iulian Moraru]

Backed out for causing multiple bc failures related to telemetry. Later discovered that there are also some xpcshell jobs that are affected by this.

• Push with failures

• Failure log for TEST-UNEXPECTED-FAIL | dom/security/test/general/browser_test_report_blocking.js | Exception finding telemetry ping: TypeError: can't access property "split", fileName is undefined -

• Failure log for TEST-UNEXPECTED-FAIL | toolkit/mozapps/update/tests/browser/browser_telemetry_updatePing_downloaded_ready.js | Uncaught exception in test bound telemetry_updatePing_ready - at resource://gre/modules/TelemetryStorage.sys.mjs:1928 - {}

• Failure log for TEST-UNEXPECTED-FAIL | toolkit/components/normandy/test/browser/browser_ClientEnvironment.js | Uncaught exception in test bound testTelemetry - at resource://gre/modules/TelemetryStorage.sys.mjs:1928 - {}

• Failure log for TEST-UNEXPECTED-FAIL | toolkit/mozapps/extensions/test/xpcshell/rs-blocklist/test_blocklist_mlbf_telemetry.js

• Failure log for TEST-UNEXPECTED-FAIL | xpcshell.ini:toolkit/components/extensions/test/xpcshell/test_site_permissions.js

• Failure log for TEST-UNEXPECTED-FAIL | xpcshell-remote.ini:toolkit/components/extensions/test/xpcshell/test_ext_storage_idb_data_migration.js

• Failure log for TEST-UNEXPECTED-FAIL | browser/components/uitour/test/browser_UITour.js | Exception finding uitour telemetry ping: TypeError: can't access property "split", fileName is undefined -

• Backout link

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f16b770fc5a8
Port osfile.jsm usage to IOUtils in TelemetryStorage.jsm r=chutten

Comment 8

[Natalia Csoregi [:nataliaCs]]

Backed out for causing failures on test_SyncPingIntegration.js

• backout: https://hg.mozilla.org/integration/autoland/rev/e6d018721d488754d378774982bb273042c845d2
• push: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&revision=f16b770fc5a8f5c0dfdb8aa39f3874b969fdd2cf&selectedTaskRun=Op6wd80FQMWlGyky5U-Pxg.0
• failure log: https://treeherder.mozilla.org/logviewer?job_id=407529086&repo=autoland&lineNumber=3457

[task 2023-03-02T07:26:46.247Z] 07:26:46     INFO -  TEST-PASS | toolkit/components/terminator/tests/xpcshell/test_terminator_reload.js | took 4478ms
[task 2023-03-02T07:26:46.249Z] 07:26:46     INFO -  Retrying tests that failed when run in parallel.
[task 2023-03-02T07:26:46.250Z] 07:26:46     INFO -  TEST-START | toolkit/components/telemetry/tests/unit/test_SyncPingIntegration.js
[task 2023-03-02T07:31:46.259Z] 07:31:46  WARNING -  TEST-UNEXPECTED-TIMEOUT | toolkit/components/telemetry/tests/unit/test_SyncPingIntegration.js | Test timed out
[task 2023-03-02T07:31:46.259Z] 07:31:46     INFO -  TEST-INFO took 300000ms
[task 2023-03-02T07:31:46.260Z] 07:31:46     INFO -  >>>>>>>
[task 2023-03-02T07:31:46.260Z] 07:31:46     INFO -  (xpcshell/head.js) | test MAIN run_test pending (1)
[task 2023-03-02T07:31:46.261Z] 07:31:46     INFO -  (xpcshell/head.js) | test run_next_test 0 pending (2)
[task 2023-03-02T07:31:46.262Z] 07:31:46     INFO -  (xpcshell/head.js) | test MAIN run_test finished (2)
[task 2023-03-02T07:31:46.262Z] 07:31:46     INFO -  running event loop
[task 2023-03-02T07:31:46.263Z] 07:31:46     INFO -  toolkit/components/telemetry/tests/unit/test_SyncPingIntegration.js | Starting test_setup
[task 2023-03-02T07:31:46.264Z] 07:31:46     INFO -  (xpcshell/head.js) | test test_setup pending (2)
[task 2023-03-02T07:31:46.265Z] 07:31:46     INFO -  (xpcshell/head.js) | test run_next_test 0 finished (2)
[task 2023-03-02T07:31:46.265Z] 07:31:46     INFO -  (xpcshell/head.js) | test run_next_test 1 pending (2)
[task 2023-03-02T07:31:46.266Z] 07:31:46     INFO -  (xpcshell/head.js) | test test_setup finished (2)
[task 2023-03-02T07:31:46.267Z] 07:31:46     INFO -  toolkit/components/telemetry/tests/unit/test_SyncPingIntegration.js | Starting test_register_twice_fails
[task 2023-03-02T07:31:46.268Z] 07:31:46     INFO -  (xpcshell/head.js) | test test_register_twice_fails pending (2)
[task 2023-03-02T07:31:46.268Z] 07:31:46     INFO -  TEST-PASS | toolkit/components/telemetry/tests/unit/test_SyncPingIntegration.js | test_register_twice_fails - [test_register_twice_fails : 19] ..

Comment 9

[Alex Finder]

(In reply to Natalia Csoregi [:nataliaCs] from comment #8)

Backed out for causing failures on test_SyncPingIntegration.js

• backout: https://hg.mozilla.org/integration/autoland/rev/e6d018721d488754d378774982bb273042c845d2
• push: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&revision=f16b770fc5a8f5c0dfdb8aa39f3874b969fdd2cf&selectedTaskRun=Op6wd80FQMWlGyky5U-Pxg.0
• failure log: https://treeherder.mozilla.org/logviewer?job_id=407529086&repo=autoland&lineNumber=3457

[task 2023-03-02T07:26:46.247Z] 07:26:46     INFO -  TEST-PASS | toolkit/components/terminator/tests/xpcshell/test_terminator_reload.js | took 4478ms
[task 2023-03-02T07:26:46.249Z] 07:26:46     INFO -  Retrying tests that failed when run in parallel.
[task 2023-03-02T07:26:46.250Z] 07:26:46     INFO -  TEST-START | toolkit/components/telemetry/tests/unit/test_SyncPingIntegration.js
[task 2023-03-02T07:31:46.259Z] 07:31:46  WARNING -  TEST-UNEXPECTED-TIMEOUT | toolkit/components/telemetry/tests/unit/test_SyncPingIntegration.js | Test timed out
[task 2023-03-02T07:31:46.259Z] 07:31:46     INFO -  TEST-INFO took 300000ms
[task 2023-03-02T07:31:46.260Z] 07:31:46     INFO -  >>>>>>>
[task 2023-03-02T07:31:46.260Z] 07:31:46     INFO -  (xpcshell/head.js) | test MAIN run_test pending (1)
[task 2023-03-02T07:31:46.261Z] 07:31:46     INFO -  (xpcshell/head.js) | test run_next_test 0 pending (2)
[task 2023-03-02T07:31:46.262Z] 07:31:46     INFO -  (xpcshell/head.js) | test MAIN run_test finished (2)
[task 2023-03-02T07:31:46.262Z] 07:31:46     INFO -  running event loop
[task 2023-03-02T07:31:46.263Z] 07:31:46     INFO -  toolkit/components/telemetry/tests/unit/test_SyncPingIntegration.js | Starting test_setup
[task 2023-03-02T07:31:46.264Z] 07:31:46     INFO -  (xpcshell/head.js) | test test_setup pending (2)
[task 2023-03-02T07:31:46.265Z] 07:31:46     INFO -  (xpcshell/head.js) | test run_next_test 0 finished (2)
[task 2023-03-02T07:31:46.265Z] 07:31:46     INFO -  (xpcshell/head.js) | test run_next_test 1 pending (2)
[task 2023-03-02T07:31:46.266Z] 07:31:46     INFO -  (xpcshell/head.js) | test test_setup finished (2)
[task 2023-03-02T07:31:46.267Z] 07:31:46     INFO -  toolkit/components/telemetry/tests/unit/test_SyncPingIntegration.js | Starting test_register_twice_fails
[task 2023-03-02T07:31:46.268Z] 07:31:46     INFO -  (xpcshell/head.js) | test test_register_twice_fails pending (2)
[task 2023-03-02T07:31:46.268Z] 07:31:46     INFO -  TEST-PASS | toolkit/components/telemetry/tests/unit/test_SyncPingIntegration.js | test_register_twice_fails - [test_register_twice_fails : 19] ..

== Change summary for alert #37521 (as of Sun, 05 Mar 2023 00:56:50 GMT) ==

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)	Performance Profiles
4%	google-docs FirstVisualChange	windows10-64-shippable-qr	cold fission webrender	766.83 -> 735.92	Before/After
3%	twitter SpeedIndex	windows10-64-shippable-qr	bytecode-cached cold fission webrender	1,108.17 -> 1,079.67	Before/After
2%	twitter ContentfulSpeedIndex	windows10-64-shippable-qr	bytecode-cached cold fission webrender	1,171.38 -> 1,142.17	Before/After
2%	twitter PerceptualSpeedIndex	windows10-64-shippable-qr	bytecode-cached cold fission webrender	680.88 -> 666.75	Before/After

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=37521

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:barret, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit auto_nag documentation.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/78774d55fd32
Port osfile.jsm usage to IOUtils in TelemetryStorage.jsm r=chutten

Comment 12

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/78774d55fd32