Closed Bug 1802551 Opened 1 year ago Closed 1 year ago

Remove osfile.jsm usage from toolkit/components/telemetry/app/TelemetryStorage.jsm

Categories

(Toolkit Graveyard :: OS.File, task, P1)

Product:
Toolkit Graveyard
Component:
OS.File
Type:
task

Tracking

(firefox114 fixed)

Status:
RESOLVED FIXED
Milestone:
114 Branch
Tracking Flags:
Tracking Status
firefox114 --- fixed

People

(Reporter: barret, Assigned: barret)

References

Details

(Keywords: perf-alert)

Attachments

(1 file)

Bug 1802551 - Port osfile.jsm usage to IOUtils in TelemetryStorage.jsm r?chutten
48 bytes, text/x-phabricator-request
Details | Review
Summary: Remove osfile.jsm usage from toolkit/components/telemetry/app/TelemetrySend.jsm → Remove osfile.jsm usage from toolkit/components/telemetry/app/TelemetryStorage.jsm
Duplicate of this bug: 1804692
Duplicate of this bug: 1813765
Blocks: 1816155
Duplicate of this bug: 1815322
Pushed by brennie@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5fb1ba731fbc
Port osfile.jsm usage to IOUtils in TelemetryStorage.jsm r=chutten

Backed out for causing multiple bc failures related to telemetry. Later discovered that there are also some xpcshell jobs that are affected by this.

Flags: needinfo?(brennie)
Blocks: 1772932
Pushed by brennie@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f16b770fc5a8
Port osfile.jsm usage to IOUtils in TelemetryStorage.jsm r=chutten
Regressions: 1819838

Backed out for causing failures on test_SyncPingIntegration.js

[task 2023-03-02T07:26:46.247Z] 07:26:46     INFO -  TEST-PASS | toolkit/components/terminator/tests/xpcshell/test_terminator_reload.js | took 4478ms
[task 2023-03-02T07:26:46.249Z] 07:26:46     INFO -  Retrying tests that failed when run in parallel.
[task 2023-03-02T07:26:46.250Z] 07:26:46     INFO -  TEST-START | toolkit/components/telemetry/tests/unit/test_SyncPingIntegration.js
[task 2023-03-02T07:31:46.259Z] 07:31:46  WARNING -  TEST-UNEXPECTED-TIMEOUT | toolkit/components/telemetry/tests/unit/test_SyncPingIntegration.js | Test timed out
[task 2023-03-02T07:31:46.259Z] 07:31:46     INFO -  TEST-INFO took 300000ms
[task 2023-03-02T07:31:46.260Z] 07:31:46     INFO -  >>>>>>>
[task 2023-03-02T07:31:46.260Z] 07:31:46     INFO -  (xpcshell/head.js) | test MAIN run_test pending (1)
[task 2023-03-02T07:31:46.261Z] 07:31:46     INFO -  (xpcshell/head.js) | test run_next_test 0 pending (2)
[task 2023-03-02T07:31:46.262Z] 07:31:46     INFO -  (xpcshell/head.js) | test MAIN run_test finished (2)
[task 2023-03-02T07:31:46.262Z] 07:31:46     INFO -  running event loop
[task 2023-03-02T07:31:46.263Z] 07:31:46     INFO -  toolkit/components/telemetry/tests/unit/test_SyncPingIntegration.js | Starting test_setup
[task 2023-03-02T07:31:46.264Z] 07:31:46     INFO -  (xpcshell/head.js) | test test_setup pending (2)
[task 2023-03-02T07:31:46.265Z] 07:31:46     INFO -  (xpcshell/head.js) | test run_next_test 0 finished (2)
[task 2023-03-02T07:31:46.265Z] 07:31:46     INFO -  (xpcshell/head.js) | test run_next_test 1 pending (2)
[task 2023-03-02T07:31:46.266Z] 07:31:46     INFO -  (xpcshell/head.js) | test test_setup finished (2)
[task 2023-03-02T07:31:46.267Z] 07:31:46     INFO -  toolkit/components/telemetry/tests/unit/test_SyncPingIntegration.js | Starting test_register_twice_fails
[task 2023-03-02T07:31:46.268Z] 07:31:46     INFO -  (xpcshell/head.js) | test test_register_twice_fails pending (2)
[task 2023-03-02T07:31:46.268Z] 07:31:46     INFO -  TEST-PASS | toolkit/components/telemetry/tests/unit/test_SyncPingIntegration.js | test_register_twice_fails - [test_register_twice_fails : 19] ..
Flags: needinfo?(brennie)

(In reply to Natalia Csoregi [:nataliaCs] from comment #8)

Backed out for causing failures on test_SyncPingIntegration.js

[task 2023-03-02T07:26:46.247Z] 07:26:46     INFO -  TEST-PASS | toolkit/components/terminator/tests/xpcshell/test_terminator_reload.js | took 4478ms
[task 2023-03-02T07:26:46.249Z] 07:26:46     INFO -  Retrying tests that failed when run in parallel.
[task 2023-03-02T07:26:46.250Z] 07:26:46     INFO -  TEST-START | toolkit/components/telemetry/tests/unit/test_SyncPingIntegration.js
[task 2023-03-02T07:31:46.259Z] 07:31:46  WARNING -  TEST-UNEXPECTED-TIMEOUT | toolkit/components/telemetry/tests/unit/test_SyncPingIntegration.js | Test timed out
[task 2023-03-02T07:31:46.259Z] 07:31:46     INFO -  TEST-INFO took 300000ms
[task 2023-03-02T07:31:46.260Z] 07:31:46     INFO -  >>>>>>>
[task 2023-03-02T07:31:46.260Z] 07:31:46     INFO -  (xpcshell/head.js) | test MAIN run_test pending (1)
[task 2023-03-02T07:31:46.261Z] 07:31:46     INFO -  (xpcshell/head.js) | test run_next_test 0 pending (2)
[task 2023-03-02T07:31:46.262Z] 07:31:46     INFO -  (xpcshell/head.js) | test MAIN run_test finished (2)
[task 2023-03-02T07:31:46.262Z] 07:31:46     INFO -  running event loop
[task 2023-03-02T07:31:46.263Z] 07:31:46     INFO -  toolkit/components/telemetry/tests/unit/test_SyncPingIntegration.js | Starting test_setup
[task 2023-03-02T07:31:46.264Z] 07:31:46     INFO -  (xpcshell/head.js) | test test_setup pending (2)
[task 2023-03-02T07:31:46.265Z] 07:31:46     INFO -  (xpcshell/head.js) | test run_next_test 0 finished (2)
[task 2023-03-02T07:31:46.265Z] 07:31:46     INFO -  (xpcshell/head.js) | test run_next_test 1 pending (2)
[task 2023-03-02T07:31:46.266Z] 07:31:46     INFO -  (xpcshell/head.js) | test test_setup finished (2)
[task 2023-03-02T07:31:46.267Z] 07:31:46     INFO -  toolkit/components/telemetry/tests/unit/test_SyncPingIntegration.js | Starting test_register_twice_fails
[task 2023-03-02T07:31:46.268Z] 07:31:46     INFO -  (xpcshell/head.js) | test test_register_twice_fails pending (2)
[task 2023-03-02T07:31:46.268Z] 07:31:46     INFO -  TEST-PASS | toolkit/components/telemetry/tests/unit/test_SyncPingIntegration.js | test_register_twice_fails - [test_register_twice_fails : 19] ..

== Change summary for alert #37521 (as of Sun, 05 Mar 2023 00:56:50 GMT) ==

Improvements:

Ratio Test Platform Options Absolute values (old vs new) Performance Profiles
4% google-docs FirstVisualChange windows10-64-shippable-qr cold fission webrender 766.83 -> 735.92 Before/After
3% twitter SpeedIndex windows10-64-shippable-qr bytecode-cached cold fission webrender 1,108.17 -> 1,079.67 Before/After
2% twitter ContentfulSpeedIndex windows10-64-shippable-qr bytecode-cached cold fission webrender 1,171.38 -> 1,142.17 Before/After
2% twitter PerceptualSpeedIndex windows10-64-shippable-qr bytecode-cached cold fission webrender 680.88 -> 666.75 Before/After

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=37521

Keywords: perf-alert
Blocks: 1821983

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:barret, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit auto_nag documentation.

Flags: needinfo?(chutten)
Flags: needinfo?(brennie)
Flags: needinfo?(chutten)
Pushed by brennie@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/78774d55fd32
Port osfile.jsm usage to IOUtils in TelemetryStorage.jsm r=chutten
See Also: → 1826346

https://hg.mozilla.org/mozilla-central/rev/78774d55fd32

Status: NEW → RESOLVED
Closed: 1 year ago
status-firefox114: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 114 Branch
Flags: needinfo?(brennie)
Regressions: 1829855
Regressions: 1833463
Product: Toolkit → Toolkit Graveyard
No longer regressions: 1833463
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: