1802616 - mozregression can't install builds anymore

Status: RESOLVED FIXED

(Testing :: mozregression, defect, P2)

Description

[Timothy Nikkel (:tnikkel)]

Same result trying to run a build from 2021. Same result on a mac running 12.6 or a different mac running 10.15.7. Was working recently. It works on a Windows machine.

If I create a venv (not sure if necessary) and then install mozregression there and run it outside of a tree without mach it seems to work fine.

src % ./mach mozregression -d --launch 2022-11-25
0:00.00 DEBUG: Sending usage ping (OOP)
0:00.01 DEBUG: Get URLs for 2022-11-25
0:00.01 DEBUG: redo: attempt 1/3
0:00.01 DEBUG: redo: retry: calling _default_get with args: ('https://archive.mozilla.org/pub/firefox/nightly/2022/11/',), kwargs: {'auth': None}, attempt #1
0:00.01 DEBUG: urllib3.connectionpool: Starting new HTTPS connection (1): archive.mozilla.org:443
0:00.76 DEBUG: urllib3.connectionpool: https://archive.mozilla.org:443 "GET /pub/firefox/nightly/2022/11/ HTTP/1.1" 200 1458
0:00.82 DEBUG: got build_urls ['https://archive.mozilla.org/pub/firefox/nightly/2022/11/2022-11-25-21-45-46-mozilla-central/', 'https://archive.mozilla.org/pub/firefox/nightly/2022/11/2022-11-25-09-28-06-mozilla-central/']
0:00.82 DEBUG: Fetching build info from https://archive.mozilla.org/pub/firefox/nightly/2022/11/2022-11-25-21-45-46-mozilla-central/
0:00.82 DEBUG: redo: attempt 1/3
0:00.82 DEBUG: redo: retry: calling _default_get with args: ('https://archive.mozilla.org/pub/firefox/nightly/2022/11/2022-11-25-21-45-46-mozilla-central/',), kwargs: {'auth': None}, attempt #1
0:00.82 DEBUG: Fetching build info from https://archive.mozilla.org/pub/firefox/nightly/2022/11/2022-11-25-09-28-06-mozilla-central/
0:00.82 DEBUG: redo: attempt 1/3
0:00.82 DEBUG: redo: retry: calling _default_get with args: ('https://archive.mozilla.org/pub/firefox/nightly/2022/11/2022-11-25-09-28-06-mozilla-central/',), kwargs: {'auth': None}, attempt #1
0:00.82 DEBUG: urllib3.connectionpool: Starting new HTTPS connection (2): archive.mozilla.org:443
0:01.10 DEBUG: urllib3.connectionpool: https://archive.mozilla.org:443 "GET /pub/firefox/nightly/2022/11/2022-11-25-21-45-46-mozilla-central/ HTTP/1.1" 200 None
0:01.12 DEBUG: urllib3.connectionpool: https://archive.mozilla.org:443 "GET /pub/firefox/nightly/2022/11/2022-11-25-09-28-06-mozilla-central/ HTTP/1.1" 200 3400
0:01.69 DEBUG: got valid_builds [(0, {'build_url': 'https://archive.mozilla.org/pub/firefox/nightly/2022/11/2022-11-25-21-45-46-mozilla-central/firefox-109.0a1.en-US.mac.dmg', 'build_txt_url': 'https://archive.mozilla.org/pub/firefox/nightly/2022/11/2022-11-25-21-45-46-mozilla-central/firefox-109.0a1.en-US.mac.txt'}), (1, {'build_url': 'https://archive.mozilla.org/pub/firefox/nightly/2022/11/2022-11-25-09-28-06-mozilla-central/firefox-109.0a1.en-US.mac.dmg', 'build_txt_url': 'https://archive.mozilla.org/pub/firefox/nightly/2022/11/2022-11-25-09-28-06-mozilla-central/firefox-109.0a1.en-US.mac.txt'})]
0:01.69 DEBUG: Update build info from {'build_url': 'https://archive.mozilla.org/pub/firefox/nightly/2022/11/2022-11-25-21-45-46-mozilla-central/firefox-109.0a1.en-US.mac.dmg', 'build_txt_url': 'https://archive.mozilla.org/pub/firefox/nightly/2022/11/2022-11-25-21-45-46-mozilla-central/firefox-109.0a1.en-US.mac.txt'}
0:01.69 DEBUG: Fetching txt info from https://archive.mozilla.org/pub/firefox/nightly/2022/11/2022-11-25-21-45-46-mozilla-central/firefox-109.0a1.en-US.mac.txt
0:01.69 DEBUG: redo: attempt 1/3
0:01.69 DEBUG: redo: retry: calling _default_get with args: ('https://archive.mozilla.org/pub/firefox/nightly/2022/11/2022-11-25-21-45-46-mozilla-central/firefox-109.0a1.en-US.mac.txt',), kwargs: {}, attempt #1
0:01.83 DEBUG: urllib3.connectionpool: https://archive.mozilla.org:443 "GET /pub/firefox/nightly/2022/11/2022-11-25-21-45-46-mozilla-central/firefox-109.0a1.en-US.mac.txt HTTP/1.1" 200 99
0:01.84 INFO: Using local file: .mozilla/mozregression/persist/2022-11-25--mozilla-central--firefox-109.0a1.en-US.mac.dmg
0:01.84 INFO: Running mozilla-central build for 2022-11-25
0:15.80 DEBUG: codesign verify exit code: 0
0:15.80 ERROR: Unable to install .mozilla/mozregression/persist/2022-11-25--mozilla-central--firefox-109.0a1.en-US.mac.dmg (error: 'list' object has no attribute 'version')
0:15.80 ERROR: Unable to install .mozilla/mozregression/persist/2022-11-25--mozilla-central--firefox-109.0a1.en-US.mac.dmg (error: 'list' object has no attribute 'version')

Comment 1

[Zeid [:zeid]]

It looks like the latest version of mozinfo published on PyPI is slightly older than the version that's being used when run using mach. This commit which was shortly after the last release seems to be the culprit and is backwards-incompatible with what's on PyPI when it comes to mozinfo.os_version. This would explain why when running outside mach things work as expected.

Comment 2

[Zeid [:zeid]]

Attachment: GitHub Pull Request

Comment 3

[Zeid [:zeid]]

Fixed in 5.2.1.

Comment 4

[Timothy Nikkel (:tnikkel)]

Thanks for the quick fix!