1802640 - The download from https://www.thinkbroadband.com/download fails after it's resumed with HTTPS-only enabled

Status: RESOLVED DUPLICATE of bug 1725390

(Core :: DOM: Security, defect)

Description

[Chris Peterson [:cpeterson]]

From github: https://github.com/mozilla-mobile/focus-android/issues/7224.

Steps to reproduce

1. Go to https://www.thinkbroadband.com/download.
2. Start downloading a file, by confirming the HTTP prompt.
3. Pause the download from the Android notification bar.
4. Resume the download, and observe if the download actually continues.

Expected behavior

The download continues without issues.

Actual behavior

The download continues for a couple of seconds, without progressing, then fails.
If the download is not paused, then resumed, it completes without issues.

Device information

• Android device: OnePlus 5T (Android 10), and Sony Xperia Z5 Premium (Android 7.1.1)
• Focus version: Focus Nightly 103.0a1 from 6/15, Beta 102.0.0-beta.4
• Not reproducible on other sites.
• Not reproducible on Fenix Nightly from 6/14
• Please see the short video:

https://user-images.githubusercontent.com/40694158/173836539-7d23361e-8b30-4903-99a6-9416cda37144.mp4

Change performed by the Move to Bugzilla add-on.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:cpeterson, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 2

[Mihai Adrian Carare [:mcarare]]

This is also reproduced in Fenix on some devices.

Comment 3

[Chris Peterson [:cpeterson]]

(In reply to Mihai Adrian Carare [:mcarare] from comment #2)

This is also reproduced in Fenix on some devices.

In that case, I'll move this bug from the Focus::General components to Fenix::Downloads.

Comment 4

[Mihai Adrian Carare [:mcarare]]

Edited: double posting.

Comment 5

[Mihai Adrian Carare [:mcarare]]

On further investigation, this is not device dependent, but it only occurs when HTTPS only is enabled, and the initial download request is made on a website that does not support HTTPS and needs pressing the option "continue to HTTP site" in order to initiate the download.
When the download is resumed and after pausing it fails with:

GeckoConsole: E [JavaScript Error: "HTTPS-Only Mode: Upgrading insecure request “https://ipv4.download.thinkbroadband.com/512MB.zip” failed. (M6-C14)"]

AbstractFe...oadService : E Unable to complete download for acbd4aae-1197-4800-a892-ef006ebfdefe marked as FAILED java.io.IOException: org.mozilla.geckoview.WebRequestError: Request failed, error=0x33, category=0x3 at mozilla.components.browser.engine.gecko.fetch.GeckoViewFetchClient.fetch(GeckoViewFetchClient.kt:61) at org.mozilla.focus.engine.ClientWrapper.fetch(ClientWrapper.kt:22) at mozilla.components.feature.downloads.AbstractFetchDownloadService.performDownload$feature_downloads_debug(AbstractFetchDownloadService.kt:686) at mozilla.components.feature.downloads.AbstractFetchDownloadService.performDownload$feature_downloads_debug$default(AbstractFetchDownloadService.kt:667) at mozilla.components.feature.downloads.AbstractFetchDownloadService.startDownloadJob$feature_downloads_debug(AbstractFetchDownloadService.kt:429) at mozilla.components.feature.downloads.AbstractFetchDownloadService$broadcastReceiver$2$1$onReceive$1.invokeSuspend(AbstractFetchDownloadService.kt:182) at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33) at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:106) at kotlinx.coroutines.internal.LimitedDispatcher.run(LimitedDispatcher.kt:42) at kotlinx.coroutines.scheduling.TaskImpl.run(Tasks.kt:95) at kotlinx.coroutines.scheduling.CoroutineScheduler.runSafely(CoroutineScheduler.kt:570) at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.executeTask(CoroutineScheduler.kt:750) at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.runWorker(CoroutineScheduler.kt:677) at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.run(CoroutineScheduler.kt:664) Caused by: org.mozilla.geckoview.WebRequestError: Request failed, error=0x33, category=0x3 at org.mozilla.gecko.mozglue.GeckoLoader.nativeRun(Native Method) at org.mozilla.gecko.GeckoThread.run(GeckoThread.java:677)

Comment 6

[Mihai Adrian Carare [:mcarare]]

The same STR also causes a download failure in the desktop app with HTTPS-only enabled.

Comment 7

[miralobontiu]

I was able to reproduce this issue on all the latest Focus builds: RC 109.2.0, Beta 110.0b4, and Nightly 111.0a1 from 1/29 with the following devices:

• Lenovo tablet M10 (Android 10), and
• Google Pixel 6 (Android 13).