1802817 - Update Gradle to version 7.6.1 and Android Gradle Plugin to 7.4.1

Status: RESOLVED FIXED

(Fenix :: General, task, P2)

Description

[Ryan VanderMeulen [:RyanVM]]

Release notes:
https://docs.gradle.org/7.6/release-notes.html

Comment 1

[Ryan VanderMeulen [:RyanVM]]

This appears to work fine with Fenix/Focus/r-b, but on AC we're hitting bustage with the refactored Dependencies plugin:

FAILURE: Build failed with an exception.
* Where:
Build file '/builds/worker/checkouts/vcs/android-components/build.gradle' line: 31
* What went wrong:
A problem occurred evaluating root project 'android-components'.
> No such property: tools_androidgradle for class: org.gradle.api.artifacts.dsl.Dependencies

From the upgrade guide, it's not entirely clear to me offhand what the breaking change is.

Comment 2

[Ryan VanderMeulen [:RyanVM]]

Gabriel, any ideas about what to do regarding the bustage noted in comment 1? Presumably that'll be an issue for Fenix/Focus eventually as well.

Comment 3

[Gabriel Luong [:gl] (ΦωΦ)]

Do you have a PR with CI logs that we could look at?

Comment 4

[Ryan VanderMeulen [:RyanVM]]

I hadn't created the PR yet, but the branch exists:
https://github.com/mozilla-mobile/firefox-android/commit/1dcb8fb572c8c8a94bd78cde17239e7822627662

https://firefox-ci-tc.services.mozilla.com/tasks/UjekkspjQSCd4i_utnnsIA/runs/0/logs/public/logs/live.log

It does reproduce locally as well.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Attachment: [mozilla-mobile/fenix] Bug 1802817 - Update Fenix to Gradle 7.6 (#27993)

Comment 6

[BMO Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1802817 - Update firefox-android to Gradle 7.6 (#507)

Comment 7

[Ryan VanderMeulen [:RyanVM]]

I've gone ahead and created the firefox-android PR so the logs are easier to find.
https://firefox-ci-tc.services.mozilla.com/tasks/bDFrM1T-Tg2w-ZgY0ezVHA/runs/5/logs/public/logs/live.log

FAILURE: Build failed with an exception.

* Where:
Build file '/builds/worker/checkouts/vcs/android-components/build.gradle' line: 31

* What went wrong:
A problem occurred evaluating root project 'android-components'.
> No such property: tools_androidgradle for class: org.gradle.api.artifacts.dsl.Dependencies

Comment 8

[Mihai Adrian Carare [:mcarare]]

This will likely need a renaming of the Dependencies object in AC in order to avoid clashes with the org.gradle.api.artifacts.dsl.Dependencies class newly introduced in 7.6.

Comment 9

[Gabriel Luong [:gl] (ΦωΦ)]

Clearing NI since https://bugzilla.mozilla.org/show_bug.cgi?id=1802817#c8 is probably what we need.

Comment 10

[Gabriel Luong [:gl] (ΦωΦ)]

In order to upgrade Gradle, we need to rename Dependencies currently in https://github.com/mozilla-mobile/firefox-android/blob/b4e0474f2481093e065479ac8713e7a0e06c5048/android-components/plugins/dependencies/src/main/java/DependenciesPlugin.kt#L98 to avoid clashes with org.gradle.api.artifacts.dsl.Dependencies class newly introduced in 7.6.

@csadilek We are wondering about the best names here - ACDependencies, AndroidComponentsDependencies, ComponentsDependencies or some other alternative. Any preferences?

Comment 11

[Christian Sadilek [:csadilek]]

:gl, My preference would be ComponentDependencies. That's in line with FocusDependencies and FenixDependencies.

BTW, I've noticed that we need to rename Dependencies.kt to FenixDependencies on our staging repo to align with Focus. We renamed the type, but not the file.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9311122 [details] [review]
[mozilla-mobile/fenix] Bug 1802817 - Update Fenix to Gradle 7.6 (#27993)

Setting the Fenix PR to obsolete. We should roll it into the firefox-android PR to land after the migration next week.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

v7.6.1 is out now and is a recommended update over v7.6:
https://github.com/gradle/gradle/releases/tag/v7.6.1

Comment 14

[Chris Peterson [:cpeterson]]

No need to uplift to 111

Comment 15

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1802817 - Upgrade Gradle to 7.6.1 version and Android Gradle Plugin to 7.4.2 (#1482)

Comment 16

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1802817 - Replace deprecated main with mainClass. (#2563)

Comment 17

[BMO Github Automation]

Authored by https://github.com/mcarare
https://github.com/mozilla-mobile/firefox-android/commit/1031a37c115dd3745781772506b13b3039cc5734
[main] Bug 1802817 - Replace deprecated main with mainClass.

Comment 18

[Mihai Adrian Carare [:mcarare]]

No QA needed for the build system change.