1802957 - Add preferences to override system fonts

Status: RESOLVED FIXED

(Core :: Widget, task, P3)

Description

[Emilio Cobos Álvarez (:emilio)]

Much like we have preferences to override ints / floats / colors here, it seems having prefs for fonts would be useful (if only for testing without having to change system settings).

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1802957 - Remove non-standard and unused system font values. r=jfkthame

And hide internal but used values. System fonts are not exposed in the
computed style so this should be fine.

If we need the old values for some obscure reason, it's trivial to alias
them to e.g., menu or so.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1802957 - Remove windows-specific condition for system font font-size adjustment. r=jfkthame

Now that the non-native theme is everywhere, let's do this consistently
across platforms.

Note that these fonts aren't used for XUL anyways, so this shouldn't
change behavior in practice.

Depends on D163269

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1802957 - Allow to specify system fonts via prefs. r=jfkthame

Much like we allow to do so with colors and ints/floats.

Read a string pref for the font name, and a few float/bools for
size/weight/italic, which is what our LookAndFeel back-end supports.

Depends on D163270

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ffe8d999e454
Remove non-standard and unused system font values. r=jfkthame
https://hg.mozilla.org/integration/autoland/rev/60822417a838
Remove windows-specific condition for system font font-size adjustment. r=jfkthame
https://hg.mozilla.org/integration/autoland/rev/649c190f6c29
Allow to specify system fonts via prefs. r=jfkthame

Comment 5

[Marian-Vasile Laza]

Backed out 3 changesets (Bug 1802957) for causing mochitest failures on test_unstyled_control_height.html.
Backout link
Push with failures <--> 3
Failure Log

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f331a560b37c
Remove non-standard and unused system font values. r=jfkthame
https://hg.mozilla.org/integration/autoland/rev/5fd98b1efb0a
Remove windows-specific condition for system font font-size adjustment. r=jfkthame
https://hg.mozilla.org/integration/autoland/rev/f1cdc72ea3d3
Allow to specify system fonts via prefs. r=jfkthame

Comment 7

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/f331a560b37c
https://hg.mozilla.org/mozilla-central/rev/5fd98b1efb0a
https://hg.mozilla.org/mozilla-central/rev/f1cdc72ea3d3