1802977 - Crash in [@ nsWindow::Destroy]

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Andrew Osmond [:aosmond] (he/him)]

Crash report: https://crash-stats.mozilla.org/report/index/8fd77808-9f39-40ed-8713-68c270221126

MOZ_CRASH Reason: MOZ_DIAGNOSTIC_ASSERT(NS_IsMainThread())

Top 10 frames of crashing thread:

0  libxul.so  nsWindow::Destroy  widget/gtk/nsWindow.cpp:581
1  libxul.so  nsWindow::~nsWindow  widget/gtk/nsWindow.cpp:456
2  libxul.so  nsWindow::~nsWindow  widget/gtk/nsWindow.cpp:450
3  libxul.so  nsBaseWidget::Release  widget/nsBaseWidget.cpp:132
4  libxul.so  mozilla::RefPtrTraits<nsWindow>::Release  mfbt/RefPtr.h:50
4  libxul.so  RefPtr<nsWindow>::ConstRemovingRefPtrTraits<nsWindow>::Release  mfbt/RefPtr.h:381
4  libxul.so  RefPtr<nsWindow>::~RefPtr  mfbt/RefPtr.h:81
4  libxul.so  mozilla::widget::GtkCompositorWidget::~GtkCompositorWidget  widget/gtk/GtkCompositorWidget.cpp:72
5  libxul.so  mozilla::widget::InProcessGtkCompositorWidget::~InProcessGtkCompositorWidget  widget/gtk/InProcessGtkCompositorWidget.h:16
6  libxul.so  mozilla::widget::CompositorWidget::Release  widget/CompositorWidget.h:90

Comment 1

[Andrew Osmond [:aosmond] (he/him)]

We added a check in bug 1750513 to ensure we are not freeing nsWindow off the main thread, but we do on the compositor thread.

Comment 2

[Andrew Osmond [:aosmond] (he/him)]

Is this just as simple as adding a NS_ReleaseOnMainThread call for mWidget?
https://searchfox.org/mozilla-central/rev/77a39e7595198fd30b57550749c15761d30314fb/widget/gtk/GtkCompositorWidget.cpp#69

Comment 3

[Martin Stránský [:stransky] (ni? me)]

(In reply to Andrew Osmond [:aosmond] (he/him) from comment #2)

Is this just as simple as adding a NS_ReleaseOnMainThread call for mWidget?

Looks like so, Thanks.

Comment 4

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1802977 [Linux] Release nsWindow referenced by GtkCompositorWidget from main thread by NS_ReleaseOnMainThread() r?aosmond

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9b463a0b6bfa
[Linux] Release nsWindow referenced by GtkCompositorWidget from main thread by NS_ReleaseOnMainThread() r=aosmond

Comment 6

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/9b463a0b6bfa