1803092 - We should handle error case of requestFullscreen

Status: RESOLVED FIXED

(GeckoView :: General, defect)

Description

[Makoto Kato [:m_kato]]

I found this issue when writing test of bug 1744288.

When full screen mode is entered, we call windowUtils.handleFullscreenRequests(). But we don't check any error, so if this causes error (return false), Gecko's fullscreen state is unexpected.

Desktop handles whether this call is true or false.

Comment 1

[Makoto Kato [:m_kato]]

Attachment: Bug 1803092 - GeckoView cannot enter fullscreen after error. r=#geckoview-reviewers

Actually, we don't check whether handleFullscreenRequests is successful. Then,
when it causes an error, GeckoView cannot enter full screen again since current
document's fullscreen state isn't updated.

If it causes an error, we should clean up the state like Firefox desktop.

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/37310 for changes under testing/web-platform/tests

Comment 3

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/f446e93d3e95

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot