1803190 - conscious language removal in NSS

Status: RESOLVED FIXED

(NSS :: Libraries, enhancement)

Description

[Robert Relyea]

In recent years there has been a push to remove what used to be common terms in programming that have negative racial connotations. Red Hat has been removing them from their products and are now working to help upstreams remove them from their code base where possible. The problemantic terms are master, slave, whitelist, blacklist, and are usually easily changes to main/server, client, allowlist, and blocklist (or other similiar terms, which are often more descriptive anyway). Fortunately NSS is relatively clean of these lists except for things related to the tls/ssl master key, which part of the tls spec and needs to first be handled by the tls ietf working group. The remaining scans are listed below:

*********************** Searching for slave ***************************
./.hg/store/fncache:data/automation/buildbot-slave/bbenv-example.sh.i
./.hg/store/fncache:data/automation/buildbot-slave/startbuild.bat.i
./.hg/store/fncache:data/automation/buildbot-slave/build.sh.i
./.hg/store/fncache:data/automation/buildbot-slave/reboot.bat.i
./.hg/store/undo.backup.fncache:data/automation/buildbot-slave/bbenv-example.sh.i
./.hg/store/undo.backup.fncache:data/automation/buildbot-slave/startbuild.bat.i
./.hg/store/undo.backup.fncache:data/automation/buildbot-slave/build.sh.i
./.hg/store/undo.backup.fncache:data/automation/buildbot-slave/reboot.bat.i
./automation/taskcluster/scripts/check_abi.sh:#Slightly modified from builbot-slave/build.sh
./doc/rst/legacy/python_binding_for_nss/index.rst: - Bohuslav Kabrda [e-mail]
./lib/pk11wrap/pk11auth.c: * slave applications to single crypto devices need to virtuallize the
./tests/mksymlinks:#additionally: only creat link if the slave build is present, but
************************ Searching for blacklist ***************************
./.hg/store/fncache:data/.sancov-blacklist.i
./.hg/store/undo.backup.fncache:data/.sancov-blacklist.i
./automation/clang-format/run_clang_format.sh:blacklist=(
./automation/clang-format/run_clang_format.sh: for black in "${blacklist[@]}"; do
./lib/libpkix/include/pkix_errorstrings.h:PKIX_ERRORENTRY(CERTISBLACKLISTEDATISSUANCETIME,Issuer Certificate is distrusted at the time the subordinate certifiate was issued,SEC_ERROR_UNTRUSTED_ISSUER)
./lib/libpkix/pkix/top/pkix_build.c: PKIX_ERROR(PKIX_CERTISBLACKLISTEDATISSUANCETIME);
./mach: "-blacklist=" + os.path.join(cwd, ".sancov-blacklist"),
*********************** Searching for whitelist ***************************
./automation/taskcluster/scripts/check_abi.sh: # result report with our whitelist. This allows us to silence changes
./automation/taskcluster/scripts/check_abi.sh: echo "Ignoring abidiff result ABI_CHANGE, instead we'll check for non-whitelisted differences."
./automation/taskcluster/scripts/check_abi.sh: echo "Ignoring abidiff result ABIDIFF_ABI_INCOMPATIBLE_CHANGE, instead we'll check for non-whitelisted differences."

Most of these are in comments and easily changed. The following would not be changes:

1. anything under .hg.

• These are .hg meta data and aren't changeable. The also aren't shipped with nss .tar files

2. ./doc/rst/legacy/python_binding_for_nss/index.rst: - Bohuslav Kabrda [e-mail]

• This is a persons email address based on their name, so isn't really the word 'slave'

3. ./mach: "-blacklist=" + os.path.join(cwd, ".sancov-blacklist"),

• this is a command from a tool (sancov) which NSS does not have any control over

The rest can be changed including the PKIX Error libpkix errors are not exported and are internal to NSS.

Comment 1

[Robert Relyea]

Attachment: WIP: Bug 1803190 conscious language removal in NSS

Clean up problemantic terms are master, slave, whitelist, blacklist.
These are usually easily changes to main/server, client, allowlist, and blocklist (or other similiar terms, which are often more descriptive anyway). Things related to the tls/ssl master key, which part of the tls spec and needs to first be handled by the tls ietf working group.

Comment 2

[Robert Relyea]

Checked in:
https://hg.mozilla.org/projects/nss/rev/d9b068a28a657674692abc3d1ac5a67089789e31