1803230 - [meta] Migrate from loadSubScript to ES Modules (for tests)

Status: NEW

(Core :: XPConnect, task)

Description

[Kagami Rosylight [:saschanaz] (they/them)]

It's not very IDE friendly and it makes hard to know which thing is from which script, especially when passing this as the second argument. Given that ES module system is a thing now, it probably also makes sense to migrate if possible.

Comment 1

[Mark Banner (:standard8)]

I think there's very few (if any?) cases where we use loadSubScript for importing existing modules, and where we do it is probably into worker environments where we don't currently support ES modules (although I've a feeling they use importScripts).

Whilst I think it would be a good goal to reconsider using loadSubScript where we don't really need to, I think that's a lot of work and probably separate to the esm-ification task which is focussing on migrating our existing modules across to ES modules, so that eventually we might be able to remove the jsm loader.

Comment 2

[Kagami Rosylight [:saschanaz] (they/them)]

Agreed, and that's why it's not blocking bug 1308512 but lists it as a see-also. Basically I just stumbled upon such tests using loadSubScript and thought it could be replaced, so the bug!

Comment 3

[Mark Banner (:standard8)]

(In reply to Kagami :saschanaz from comment #2)

Agreed, and that's why it's not blocking bug 1308512 but lists it as a see-also. Basically I just stumbled upon such tests using loadSubScript and thought it could be replaced, so the bug!

Sorry, I missed that being a see-also.