1803245 - Add Timeout nsiTimer onto the Document to track active IdentityCredential requests

Status: RESOLVED FIXED

(Core :: DOM: Credential Management, enhancement)

Comment 1

[Benjamin VanderSloot [:bvandersloot]]

This will make it so the timer works when we pass on rejecting the promise.

Comment 2

[Benjamin VanderSloot [:bvandersloot]]

Attachment: Bug 1803245 - Add Timeout nsiTimer onto the Document to track active IdentityCredential requests, r=timhuang!

This doesn't actually move the timer onto the document.
Instead it is the correct manual juggling of pointers via .forget() and NS_RELEASE() and some additional testing to make sure it works properly.
This passes tests where we resolve, reject immediately, and reject on timeout and has no leaks in all of those cases.
Putting the timer on the document also required putting the pending promise onto the document with it and that had further wrinkles.
I call that good enough.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1b54637116ca
Add Timeout nsiTimer onto the Document to track active IdentityCredential requests, r=timhuang

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/1b54637116ca