180336 - Add parser tests: grabpage logparse html

Status: RESOLVED FIXED

(Core :: DOM: HTML Parser, defect)

Description

[timeless]

Comment 1

[timeless]

Attachment: patch -w

adds grabpage and html (testparser)
fixes logparse so that it builds/runs.

Comment 2

[timeless]

Attachment: patch v.2 -w (fixes objdir problem)

Comment 3

[harishd]

Comment on attachment 106601 [details] [diff] [review]
patch v.2 -w (fixes objdir problem)

>Index: Makefile.in
>===================================================================
>RCS file: /cvsroot/mozilla/htmlparser/tests/Makefile.in,v
>retrieving revision 1.4
>diff -u -w -r1.4 Makefile.in
>--- Makefile.in	6 Dec 1999 22:29:49 -0000	1.4
>+++ Makefile.in	17 Nov 2002 22:22:56 -0000
>@@ -26,6 +26,10 @@
> 
> include $(DEPTH)/config/autoconf.mk
> 
>-DIRS		= outsinks
>+DIRS		= outsinks \
>+                  grabpage \
>+                  logparse \
>+                  html \
>+                  $(NULL)
> 

I believe you can cvs remove files under logparse/grabpage dir. and remove
logparse/grabpage from DIRS.

Comment 4

[Heikki Toivonen (remove -bugzilla when emailing directly)]

Comment on attachment 106601 [details] [diff] [review]
patch v.2 -w (fixes objdir problem)

I believe Harish thinks logparse could be removed. But if you or someone finds
it useful then I am ok with having it in the tree.

>Index: Makefile.in
>===================================================================
>Index: html/Makefile.in
>===================================================================
>Index: logparse/logparse.cpp
>===================================================================
>-/* -*- Mode: C++; tab-width: 2; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
>+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */

I would prefer if you left it at 2 and changed the tabs two 2 spaces.

localfile->InitWithNativePath(nsDependentCString(aSourceFilename));
>+    nsCOMPtr<nsIURI> inputURI;
> 		{
>-			fstream theOutputStream(aBaselineFilename,ios::out);
>-			sink->SetOutputStream(theOutputStream);
>+        nsCOMPtr<nsIIOService> ioService(do_GetService(kIOServiceCID, &rv));
>+        if (NS_FAILED(rv))
>+           return rv;
>+        rv = ioService->NewFileURI(localfile, getter_AddRefs(inputURI));
>+        if (NS_FAILED(rv))
>+           return rv;
>+    }
>+    localfile->InitWithNativePath(nsDependentCString(aBaselineFilename));

I am wondering about that localfile thing... Are you just reusing the same
object, or was this a mistake?

Comment 5

[timeless]

it was intentional recycling, localfile is used to get inputURI here:
>+        rv = ioService->NewFileURI(localfile, getter_AddRefs(inputURI));
and then it's just available to be used again.

ok. i checked in most of the pieces but I got spooked by a really silly include
issue which made a bit of a mess. so logparse is not currently being built. 
i'll poke it later.

Comment 6

[Heikki Toivonen (remove -bugzilla when emailing directly)]

Comment on attachment 106601 [details] [diff] [review]
patch v.2 -w (fixes objdir problem)

Somehow a + was changed to ? by me, I have no idea how... Changing it back.

Comment 7

[Mike Kaply [:mkaply]]

Attachment: OS/2 specific patch

This is the OS/2 specific changes needed for grabpage.

Comment 8

[timeless]

the pieces were checked in