1803368 - H264 encoding for webrtc is broken on Android

Status: RESOLVED FIXED

(Core :: WebRTC: Audio/Video, defect, P2)

Description

[Andreas Pehrson [:pehrsons]]

Android doesn't have OpenH264, and the plumbing for some h264 configuration options was broken in bug 1790097.

Comment 1

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1803368 - Plumb H264 configuration from sdp negotiation into libwebrtc. r?#webrtc-reviewers!

The plumbing for this was broken in
https://hg.mozilla.org/mozilla-central/rev/f3fc736c62d289ba9d7be9ed01806de7b6c00855

This patch puts the config data into SdpVideoFormat::Parameters which gets
passed into libwebrtc. Further down the line, these parameters will have to be
picked up by encoders. Subsequent patches fixes this for WebrtcGmpVideoEncoder
and WebrtcMediaDataEncoder.

Comment 2

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1803368 - In WebrtcMediaDataEncoderCodec, read H264 packetization mode from sdp params. r?#webrtc-reviewers!

Comment 3

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1803368 - Plumb packetization mode into WebrtcGmpVideoEncoder. r?#webrtc-reviewers!

Comment 4

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1803368 - Reinstate frame dropping. r?#webrtc-reviewers!

The plumbing for this was broken in
https://hg.mozilla.org/mozilla-central/rev/19f5dc65c5c2c5836b6ac78e6b7890d179fc820e

Comment 5

[Jim Mathies [:jimm]]

[Tracking Requested - why for this release]:
Issue with the latest libwebrtc update.

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1790097

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/928995955559
Plumb H264 configuration from sdp negotiation into libwebrtc. r=webrtc-reviewers,mjf
https://hg.mozilla.org/integration/autoland/rev/b7ab96b369ab
In WebrtcMediaDataEncoderCodec, read H264 packetization mode from sdp params. r=webrtc-reviewers,mjf
https://hg.mozilla.org/integration/autoland/rev/b26b28c15d1a
Plumb packetization mode into WebrtcGmpVideoEncoder. r=webrtc-reviewers,mjf
https://hg.mozilla.org/integration/autoland/rev/4ec5232d1c53
Reinstate frame dropping. r=webrtc-reviewers,mjf

Comment 8

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/928995955559
https://hg.mozilla.org/mozilla-central/rev/b7ab96b369ab
https://hg.mozilla.org/mozilla-central/rev/b26b28c15d1a
https://hg.mozilla.org/mozilla-central/rev/4ec5232d1c53