1803392 - Remove usage of temporary file when printing to PDF

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, task, P1)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Similar to the patch on bug 1724687 we should move away from using a temporary file for the print settings that we afterward have to read. This can now be changed by using a stream similar like:

    // Create a stream to write to.
    const stream = Cc["@mozilla.org/storagestream;1"].createInstance(Ci.nsIStorageStream);
    stream.init(4096, 0xffffffff);

    printSettings.outputDestination =
      Ci.nsIPrintSettings.kOutputDestinationStream;
    printSettings.outputStream = stream.getOutputStream(0);

Comment 1

[Alexandra Borovova [:Sasha]]

Attachment: Bug 1803392 - Remove usage of temporary file when printing to PDF.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b92093717dcd
Remove usage of temporary file when printing to PDF. r=webdriver-reviewers,jdescottes

Comment 3

[Marian-Vasile Laza]

Backed out changeset b92093717dcd (Bug 1803392) for wp failures on block-page-break-inside-avoid-1-print.html.
Backout link
Push with failures <--> Wp
Failure Log

Comment 4

[Alexandra Borovova [:Sasha]]

Missed to rename lazy.print.printToFile to lazy.print.printToEncodedString here: https://searchfox.org/mozilla-central/source/remote/marionette/reftest.sys.mjs#788.
Will fix it now.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d1fb5d59505f
Remove usage of temporary file when printing to PDF. r=webdriver-reviewers,jdescottes

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/d1fb5d59505f