1803470 - CardDAV discovery should try the hostname of the email provider

Status: RESOLVED FIXED

(MailNews Core :: Address Book, enhancement)

Description

[Geoff Lankow (:darktrojan)]

When we call detectAddressBooks we only look up the hostname of the location provided, which is generally everything after the @ in an email address. If the mail server hostname differs from that, and the DNS records don't point to the right place, no address books are discovered.

Case in point: @thunderbird.net is on gmail.com, which we have a preset for, because their DNS setup is no good, but we don't find it in the presets because we're looking for thunderbird.net.

Comment 1

[Geoff Lankow (:darktrojan)]

Was going to mention, the calendar discovery code does look up MX records for the same reason. But we don't even have to do that if we're in account setup.

Comment 2

[Geoff Lankow (:darktrojan)]

Correction: the calendar code does an MX lookup only to detect if it's a Google calendar. I think we should just wire in the same thing, given it's probably the most common case by far.

Comment 3

[Andrei Hajdukewycz [:sancus]]

I've corrected our setup by adding the correct SRV record. It's not really documented by Google, so I guess many admins are probably not doing it, so this still has value.

But it seems to me that we should fall back to using the hostname of the provider only if there is no SRV record, because there's probably cases where people are putting different things in the SRV records.

Comment 4

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1803470 - Use preset location in CardDAV discovery if MX records point to Google. r=sancus

This overrides the given location if and only if:

• the hostname isn't in our presets
• there's no SRV record for the hostname
• the MX record for the hostname ends with google.com

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/5a9e1108b51a
Use preset location in CardDAV discovery if MX records point to Google. r=sancus