1803486 - Minor clean up for flex container

Status: RESOLVED FIXED

(Core :: Layout: Flexbox, task)

Description

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

While investigating flex container fragmentation, I got some clean up / refactor patches accumulated, and would love them to be reviewed and landed.

Comment 1

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1803486 Part 1 - Guard logic required only by fragmentation for flex container. r?dholbert

This separation makes hacking fragmentation code easier, and readers who are not
interested in flex container fragmentation can skip it.

Comment 2

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1803486 Part 2 - Move prevInFlow definition up in nsFlexContainerFrame::Reflow(). r?dholbert

Depends on D163545

Comment 3

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1803486 Part 3 - Add SharedFlexData::Update(). r?dholbert

Depends on D163546

Comment 4

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1803486 Part 4 - Remove arguments for CheckForMinSizeAuto() and rename it. r?dholbert

The arguments are removed for the following reasons:

1. We might need to call it future patches when ReflowInput is not available.
   Although getting the cached style struct pointers from ReflowInput is cheaper,
   but getting them from the frame directly is not expensive nowadays.

2. We can initialize mNeedsMinSizeAutoResolution directly in the member
   initializer list.

Also, simplify its implementation and comments.

Depends on D163547

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a0dbe91979ec
Part 1 - Guard logic required only by fragmentation for flex container. r=dholbert
https://hg.mozilla.org/integration/autoland/rev/04e34f384702
Part 2 - Move prevInFlow definition up in nsFlexContainerFrame::Reflow(). r=dholbert
https://hg.mozilla.org/integration/autoland/rev/94d2dd381aaa
Part 3 - Add SharedFlexData::Update(). r=dholbert
https://hg.mozilla.org/integration/autoland/rev/9370e929428b
Part 4 - Remove arguments for CheckForMinSizeAuto() and rename it. r=dholbert

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/a0dbe91979ec
https://hg.mozilla.org/mozilla-central/rev/04e34f384702
https://hg.mozilla.org/mozilla-central/rev/94d2dd381aaa
https://hg.mozilla.org/mozilla-central/rev/9370e929428b