1803495 - Support initializing SourceText from AutoStableStringChar

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P3)

Description

[Ted Campbell [:tcampbell]]

There are many uses of SourceText that indirectly come from AutoStableStringChar. Add an overload to remove boilerplate and be more consistent about optimizing buffer transfers.

Comment 1

[Ted Campbell [:tcampbell]]

Attachment: Bug 1803495 - Support initializing SourceText from AutoStableStringChars. r?arai!

These two are commonly used together in eval and testing functions so add an
overload and simplify the callers. This also allows transfering buffers in more
cases to avoid additional string copies. Currently only support the char16_t
overload, but in future should also support Utf8Unit overloads.

Comment 2

[Ted Campbell [:tcampbell]]

Attachment: Bug 1803495 - Use AutoStableStringChars overload for SourceText::init. r?arai!

Remove duplicate code and transfer string buffer ownership in more cases.

Depends on D163552

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2ed79697e312
Support initializing SourceText from AutoStableStringChars. r=arai
https://hg.mozilla.org/integration/autoland/rev/f9b2f4359d23
Use AutoStableStringChars overload for SourceText::init. r=arai

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/2ed79697e312
https://hg.mozilla.org/mozilla-central/rev/f9b2f4359d23