Closed Bug 1803505 Opened 2 years ago Closed 2 years ago

Simplify the tab-pickup-container initialization

Categories

(Firefox :: Firefox View, task, P3)

task
Points:
2

Tracking

()

RESOLVED FIXED
109 Branch
Tracking Status
firefox109 --- fixed

People

(Reporter: sfoster, Assigned: sfoster)

References

Details

(Whiteboard: [fidefe-2022-firefox-view] )

Attachments

(1 file)

While working on bug 1792040 I've run into a number of issues which needlessly complicate the sequence of events which lead up to the tab pickup list being in a known and testable state.

I'd like to remove the lazy-insertion of the setup steps and tab-pickup-list children. The original thought was to avoid adding bloat to the document until those elements were needed, but with hindsight this seems like premature optimization, and not knowing exactly whether and when those elements will exist makes reasoning about the sequence and state of things more difficult than it needs to be.

  • Adds a promise that resolves when the tab-pickup-list is ready
  • Use that promise to trigger tab data request for the list when we enter the setup-complete state
  • Remove the workarounds for overlapping setup and tabs requests
Pushed by sfoster@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/35f1fc58f00f
Simplify the tab-pickup-container initialization. r=sclements
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 109 Branch
Regressions: 1805391
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: