1803513 - `events` ping without events should not be sent

Status: RESOLVED FIXED

(Data Platform and Tools :: Glean: SDK, task, P1)

Description

[Alessio Placitelli [:Dexter]]

I noticed this while helping :daisuke (his ping). For context, all we see in that ping is this:

  "metrics": {
    "uuid": {
      "legacy.telemetry.client_id": "--redacted client id--"
    }
  }

No events. For what is worth, the ping was triggered using about:glean in Firefox Desktop, but a quick analysis from Jan-Erik identified that this specific issue is on the rise.

Comment 1

[Chris H-C :chutten]

This is almost certainly due to bug 1800081 where legacy.telemetry.client_id was given lifetime: application.

I agree with the conversation on Matrix that maybe the "events" ping can be special-cased to not be sent unless there are event metrics.

Comment 2

[Alessio Placitelli [:Dexter]]

Does this make it a SDK bug?

Comment 3

[Jan-Erik Rediger [:janerik]]

If we reframe it, yes.

Comment 4

[BMO Automation]

Attachment: [mozilla/glean] bug 1803513 - Do not send 'events' ping if there are no events (#2301)

Comment 5

[Chris H-C :chutten]

chutten merged PR #2301: "bug 1803513 - Do not send 'events' ping if there are no events" in 1de4660.