1803539 - [loong64][mips64] Failed to build loong64 and mips64 simulator (use of undeclared identifier 'TlsContext'; member access into incomplete type 'JSContext')

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect, P1)

Description

[Zhao Jiazhong]

User Agent: Mozilla/5.0 (X11; Linux loongarch64; rv:91.0) Gecko/20100101 Firefox/91.0

Steps to reproduce:

Build loong64 or mips64 js simulator.

Actual results:

Got error:

In file included from Unified_cpp_js_src_jit14.cpp:2:
mozilla/mozilla-central/js/src/jit/loong64/Simulator-loong64.cpp:1496:19: error: use of undeclared identifier 'TlsContext'
JSContext* cx = TlsContext.get();
^
mozilla-central/js/src/jit/loong64/Simulator-loong64.cpp:1498:12: error: member access into incomplete type 'JSContext'
return cx->simulator();
^
mozilla/mozilla-central/obj-js-rel-loong64/dist/include/js/TypeDecls.h:27:22: note: forward declaration of 'JSContext'
struct JS_PUBLIC_API JSContext;
^
In file included from Unified_cpp_js_src_jit14.cpp:2:
mozilla/mozilla-central/js/src/jit/loong64/Simulator-loong64.cpp:2540:58: error: no member named 'ToInt32' in namespace 'JS'
if (external == intptr_t((int32_t()(double))JS::ToInt32)) {
~~~~^
mozilla-central/js/src/jit/loong64/Simulator-loong64.cpp:5218:21: error: incomplete type 'JSContext' named in nested name specifier
js::jit::Simulator JSContext::simulator() const { return simulator_; }
^~~~~~~~~~~
mozilla/mozilla-central/obj-js-rel-loong64/dist/include/js/TypeDecls.h:27:22: note: forward declaration of 'JSContext'
struct JS_PUBLIC_API JSContext;
^

Expected results:

Build loong64 and mips64 js simulator without error.

Comment 1

[Zhao Jiazhong]

It seems that it's because the Simulator-loong64.cpp and Simulator-mips64.cpp files lack two headers, and somehow this bug is triggered by a recent changeset cb0c2d593207.

Comment 2

[Zhao Jiazhong]

Attachment: Bug 1803539 - [loong64][mips64] Include the missing headers for simulator. r=jandem

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1802497

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/36a46f04eb6a
[loong64][mips64] Include the missing headers for simulator. r=jandem

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/36a46f04eb6a