Closed Bug 1803599 Opened 2 years ago Closed 1 year ago

Add type field to "ScriptEvaluateResult" for "success" or "exception"

Categories

(Remote Protocol :: WebDriver BiDi, task, P1)

task
Points:
1

Tracking

(firefox110 fixed)

RESOLVED FIXED
110 Branch
Tracking Status
firefox110 --- fixed

People

(Reporter: whimboo, Assigned: whimboo)

References

()

Details

(Whiteboard: [webdriver:m5][wptsync upstream][webdriver:relnote])

Attachments

(2 files)

Filed as: https://github.com/w3c/webdriver-bidi/issues/339

Right now the ScriptEvaluateResult could contain a result or an exception. The client can only differentiate between those depending on which field is set. There might be cases when no field or both fields are set.

To make it obvious for the client such a type field should be added to the ScriptEvaluateResult field.

Also the webdriver bidi client needs to be updated to check for that field.

Summary: Add type field to "ScriptEvaluateResult" for "result" or "exception" → Add type field to "ScriptEvaluateResult" for "success" or "exception"
Assignee: nobody → hskupin
Status: NEW → ASSIGNED

Note that we can only land the first patch for now. The webdriver test related changes have to wait until chromedriver has the type field in a release as well.

Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/99f6378962c4
[webdriver-bidi] Add type field to "ScriptEvaluateResult" for "success" or "exception". r=webdriver-reviewers,Sasha,jdescottes

Marking bug as leave-open given that we have to wait for the remaining patch to land until both Firefox and Chrome have this field set in release versions. Once that's done I'll land the test change.

Keywords: leave-open

I discussed with Maksim the landing of the remaining patch and he told me that it will be fine today. So I'm going ahead and land the remaining piece.

Blocks: webdriver:m5
Points: --- → 1
Keywords: leave-open
Priority: -- → P1
Whiteboard: [webdriver:m5]
Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/59335c2e53cb
[wdspec] Update webdriver bidi client to handle script evaluation result type. r=webdriver-reviewers,Sasha,jdescottes
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/37541 for changes under testing/web-platform/tests
Whiteboard: [webdriver:m5] → [webdriver:m5], [wptsync upstream]
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 110 Branch
Upstream PR was closed without merging
Upstream PR was closed without merging
Upstream PR was closed without merging
Upstream PR merged by moz-wptsync-bot
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/697500d6883d
[wpt PR 37541] - [Gecko Bug 1803599] [wdspec] Update webdriver bidi client to handle script evaluation result type., a=testonly
Whiteboard: [webdriver:m5], [wptsync upstream] → [webdriver:m5][wptsync upstream][webdriver:relnote]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: