1803599 - Add type field to "ScriptEvaluateResult" for "success" or "exception"

Status: RESOLVED FIXED

(Remote Protocol :: WebDriver BiDi, task, P1)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Filed as: https://github.com/w3c/webdriver-bidi/issues/339

Right now the ScriptEvaluateResult could contain a result or an exception. The client can only differentiate between those depending on which field is set. There might be cases when no field or both fields are set.

To make it obvious for the client such a type field should be added to the ScriptEvaluateResult field.

Also the webdriver bidi client needs to be updated to check for that field.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Bug 1803599 - [webdriver-bidi] Add type field to "ScriptEvaluateResult" for "success" or "exception".

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Bug 1803599 - [wdspec] Update webdriver bidi client to handle script evaluation result type.

Depends on D163830

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Note that we can only land the first patch for now. The webdriver test related changes have to wait until chromedriver has the type field in a release as well.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/99f6378962c4
[webdriver-bidi] Add type field to "ScriptEvaluateResult" for "success" or "exception". r=webdriver-reviewers,Sasha,jdescottes

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Marking bug as leave-open given that we have to wait for the remaining patch to land until both Firefox and Chrome have this field set in release versions. Once that's done I'll land the test change.

Comment 6

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/99f6378962c4

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+2]]

I discussed with Maksim the landing of the remaining patch and he told me that it will be fine today. So I'm going ahead and land the remaining piece.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/59335c2e53cb
[wdspec] Update webdriver bidi client to handle script evaluation result type. r=webdriver-reviewers,Sasha,jdescottes

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/37541 for changes under testing/web-platform/tests

Comment 10

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/59335c2e53cb

Comment 11

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 12

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 13

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 14

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/697500d6883d
[wpt PR 37541] - [Gecko Bug 1803599] [wdspec] Update webdriver bidi client to handle script evaluation result type., a=testonly

Comment 16

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/697500d6883d