1803747 - Early Hints: Collect telemetry about preloads that don't get connected back.

Status: RESOLVED FIXED

(Core :: Networking: HTTP, enhancement, P2)

Description

[Manuel Bucher [:manuel]]

It is essential to know whether there are preloads, which get started in EarlyHintPreloader, not cancelled, but also not AsyncOpened in the content process. They might cause memory leaks, as they aren't removed from the EarlyHintRegistrar.

Comment 1

[Kershaw Chang [:kershaw]]

Attachment: Bug 1803747 - Add telemetry to record the usage of EarlyHintPreloader, r=#necko

Comment 2

[Kershaw Chang [:kershaw]]

Attachment: Bug 1803747 - Clean up early hints preloaded requests at shutdown, r=#necko

Depends on D163913

Comment 3

[Kershaw Chang [:kershaw]]

Attachment: bug1803747_data_review.txt

Comment 4

[Travis Long [:travis_]]

Comment on attachment 9306867 [details]
bug1803747_data_review.txt

Load balancing, taking data-review for :chutten

Comment 5

[Travis Long [:travis_]]

Comment on attachment 9306867 [details]
bug1803747_data_review.txt

Data Review

1. Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?

Yes, through the Histograms.json file and the Probe Dictionary

2. Is there a control mechanism that allows the user to turn the data collection on and off?

Yes, through the telemetry data preferences in the application settings.

3. If the request is for permanent data collection, is there someone who will monitor the data over time?

Permanent collection to be monitored by Kershaw Jang

4. Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 1, Technical data

5. Is the data collection request for default-on or default-off?

Default-on

6. Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?

No

7. Is the data collection covered by the existing Firefox privacy notice?

Yes

8. Does the data collection use a third-party collection tool?

No

Result

data-review+

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/217179ce4f2f
Add telemetry to record the usage of EarlyHintPreloader, r=necko-reviewers,valentin
https://hg.mozilla.org/integration/autoland/rev/d03ec543cc96
Clean up early hints preloaded requests at shutdown, r=necko-reviewers,valentin

Comment 7

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/217179ce4f2f
https://hg.mozilla.org/mozilla-central/rev/d03ec543cc96