1803751 - Make some marker fields searchable in their marker schema

Nazım Can Altınova [:canova][:canaltinova on phabricator]

Assignee

Description

•

2 years ago

Currently searchable field isn't implemented in the profiler frontend. We have some naive if checks for searching fields and that's not really sustainable for new markers. I'm working on implementing this field but we need to make some of these fields searchable in the backend so we can keep the same functionality in the profiler frontend.

Nazım Can Altınova [:canova][:canaltinova on phabricator]

Assignee

Updated

•

2 years ago

Severity: -- → N/A

Priority: -- → P2

Nazım Can Altınova [:canova][:canaltinova on phabricator]

Assignee

Comment 1

•

2 years ago

Attached file Bug 1803751 - Make some marker fields searchable and bump the profile version r?julienw,florian — Details

Phabricator Automation

Updated

•

2 years ago

Assignee: nobody → canaltinova

Status: NEW → ASSIGNED

Pulsebot

Comment 2

•

2 years ago

Pushed by canaltinova@gmail.com: https://hg.mozilla.org/integration/autoland/rev/27f8690ebc50 Make some marker fields searchable and bump the profile version r=julienw

Iulian Moraru

Comment 3

•

2 years ago

Backed out for causing xpcshell failures on test_feature_mainthreadio.js.

Push with failures

Failure log

Backout link

[task 2022-12-12T15:24:21.320Z] 15:24:21     INFO -  TEST-START | tools/profiler/tests/xpcshell/test_feature_mainthreadio.js
[task 2022-12-12T15:24:21.407Z] 15:24:21  WARNING -  TEST-UNEXPECTED-FAIL | tools/profiler/tests/xpcshell/test_feature_mainthreadio.js | xpcshell return code: 0
[task 2022-12-12T15:24:21.407Z] 15:24:21     INFO -  TEST-INFO took 86ms
[task 2022-12-12T15:24:21.407Z] 15:24:21     INFO -  >>>>>>>
[task 2022-12-12T15:24:21.407Z] 15:24:21     INFO -  (xpcshell/head.js) | test MAIN run_test pending (1)
[task 2022-12-12T15:24:21.407Z] 15:24:21     INFO -  (xpcshell/head.js) | test run_next_test 0 pending (2)
[task 2022-12-12T15:24:21.408Z] 15:24:21     INFO -  (xpcshell/head.js) | test MAIN run_test finished (2)
[task 2022-12-12T15:24:21.408Z] 15:24:21     INFO -  running event loop
[task 2022-12-12T15:24:21.408Z] 15:24:21     INFO -  tools/profiler/tests/xpcshell/test_feature_mainthreadio.js | Starting
[task 2022-12-12T15:24:21.408Z] 15:24:21     INFO -  (xpcshell/head.js) | test pending (2)
[task 2022-12-12T15:24:21.408Z] 15:24:21     INFO -  (xpcshell/head.js) | test run_next_test 0 finished (2)
[task 2022-12-12T15:24:21.409Z] 15:24:21     INFO -  "CONSOLE_MESSAGE: (info) No chrome package registered for chrome://branding/locale/brand.properties"
[task 2022-12-12T15:24:21.409Z] 15:24:21     INFO -  "Get the file"
[task 2022-12-12T15:24:21.410Z] 15:24:21     INFO -  "Generate file IO on the main thread using FileUtils.openSafeFileOutputStream."
[task 2022-12-12T15:24:21.410Z] 15:24:21     INFO -  "Write to the file"
[task 2022-12-12T15:24:21.410Z] 15:24:21     INFO -  "Close the file"
[task 2022-12-12T15:24:21.410Z] 15:24:21     INFO -  "Remove the file"
[task 2022-12-12T15:24:21.410Z] 15:24:21     INFO -  "Check the FileIO markers when using the mainthreadio feature"
[task 2022-12-12T15:24:21.411Z] 15:24:21     INFO -  TEST-PASS | tools/profiler/tests/xpcshell/test_feature_mainthreadio.js |  - Found some markers - 3 > 0
[task 2022-12-12T15:24:21.411Z] 15:24:21     INFO -  TEST-PASS | tools/profiler/tests/xpcshell/test_feature_mainthreadio.js |  - Has a marker.name that starts with FileIO - true == true
[task 2022-12-12T15:24:21.411Z] 15:24:21     INFO -  TEST-PASS | tools/profiler/tests/xpcshell/test_feature_mainthreadio.js |  - Has a marker.data.type - "FileIO" == "FileIO"
<...>
[task 2022-12-12T15:24:21.418Z] 15:24:21     INFO -  TEST-PASS | tools/profiler/tests/xpcshell/test_feature_mainthreadio.js |  - The "FileIO" field "filename" matches expectations. See the test output for more information. - {"key":"filename","label":"Filename","format":"file-path","searchable":true} deepEqual {"key":"filename","label":"Filename","format":"file-path","searchable":true}
[task 2022-12-12T15:24:21.419Z] 15:24:21  WARNING -  TEST-UNEXPECTED-FAIL | tools/profiler/tests/xpcshell/test_feature_mainthreadio.js |  - The expected and actual data have the same number of items - 3 == 4
[task 2022-12-12T15:24:21.419Z] 15:24:21     INFO -  /builds/worker/workspace/build/tests/xpcshell/tests/tools/profiler/tests/xpcshell/test_feature_mainthreadio.js:null:25
[task 2022-12-12T15:24:21.419Z] 15:24:21     INFO -  /builds/worker/workspace/build/tests/xpcshell/head.js:_do_main:238
[task 2022-12-12T15:24:21.419Z] 15:24:21     INFO -  /builds/worker/workspace/build/tests/xpcshell/head.js:_execute_test:585
[task 2022-12-12T15:24:21.420Z] 15:24:21     INFO -  -e:null:1
[task 2022-12-12T15:24:21.420Z] 15:24:21     INFO -  exiting test
[task 2022-12-12T15:24:21.420Z] 15:24:21     INFO -  PID 1599 | -----------------------------------------------------
[task 2022-12-12T15:24:21.420Z] 15:24:21     INFO -  PID 1599 | The expected marker schema:
[task 2022-12-12T15:24:21.420Z] 15:24:21     INFO -  PID 1599 | -----------------------------------------------------
[task 2022-12-12T15:24:21.420Z] 15:24:21     INFO -  PID 1599 | {
[task 2022-12-12T15:24:21.421Z] 15:24:21     INFO -  PID 1599 |   "name": "FileIO",
[task 2022-12-12T15:24:21.421Z] 15:24:21     INFO -  PID 1599 |   "display": [
[task 2022-12-12T15:24:21.421Z] 15:24:21     INFO -  PID 1599 |     "marker-chart",
[task 2022-12-12T15:24:21.421Z] 15:24:21     INFO -  PID 1599 |     "marker-table",
[task 2022-12-12T15:24:21.421Z] 15:24:21     INFO -  PID 1599 |     "timeline-fileio"
[task 2022-12-12T15:24:21.421Z] 15:24:21     INFO -  PID 1599 |   ],
[task 2022-12-12T15:24:21.422Z] 15:24:21     INFO -  PID 1599 |   "data": [
[task 2022-12-12T15:24:21.422Z] 15:24:21     INFO -  PID 1599 |     {
[task 2022-12-12T15:24:21.422Z] 15:24:21     INFO -  PID 1599 |       "key": "operation",
[task 2022-12-12T15:24:21.422Z] 15:24:21     INFO -  PID 1599 |       "label": "Operation",
[task 2022-12-12T15:24:21.423Z] 15:24:21     INFO -  PID 1599 |       "format": "string",
[task 2022-12-12T15:24:21.423Z] 15:24:21     INFO -  PID 1599 |       "searchable": true
[task 2022-12-12T15:24:21.423Z] 15:24:21     INFO -  PID 1599 |     },
[task 2022-12-12T15:24:21.423Z] 15:24:21     INFO -  PID 1599 |     {
[task 2022-12-12T15:24:21.423Z] 15:24:21     INFO -  PID 1599 |       "key": "source",
[task 2022-12-12T15:24:21.423Z] 15:24:21     INFO -  PID 1599 |       "label": "Source",
[task 2022-12-12T15:24:21.423Z] 15:24:21     INFO -  PID 1599 |       "format": "string",
[task 2022-12-12T15:24:21.423Z] 15:24:21     INFO -  PID 1599 |       "searchable": true
[task 2022-12-12T15:24:21.423Z] 15:24:21     INFO -  PID 1599 |     },
[task 2022-12-12T15:24:21.423Z] 15:24:21     INFO -  PID 1599 |     {
[task 2022-12-12T15:24:21.423Z] 15:24:21     INFO -  PID 1599 |       "key": "filename",
[task 2022-12-12T15:24:21.424Z] 15:24:21     INFO -  PID 1599 |       "label": "Filename",
[task 2022-12-12T15:24:21.424Z] 15:24:21     INFO -  PID 1599 |       "format": "file-path",
[task 2022-12-12T15:24:21.429Z] 15:24:21     INFO -  PID 1599 |       "searchable": true
[task 2022-12-12T15:24:21.430Z] 15:24:21     INFO -  PID 1599 |     }
[task 2022-12-12T15:24:21.430Z] 15:24:21     INFO -  PID 1599 |   ]
[task 2022-12-12T15:24:21.430Z] 15:24:21     INFO -  PID 1599 | }
[task 2022-12-12T15:24:21.430Z] 15:24:21     INFO -  PID 1599 | -----------------------------------------------------
[task 2022-12-12T15:24:21.430Z] 15:24:21     INFO -  PID 1599 | The actual marker schema:
[task 2022-12-12T15:24:21.430Z] 15:24:21     INFO -  PID 1599 | -----------------------------------------------------
[task 2022-12-12T15:24:21.430Z] 15:24:21     INFO -  PID 1599 | {
[task 2022-12-12T15:24:21.431Z] 15:24:21     INFO -  PID 1599 |   "name": "FileIO",
[task 2022-12-12T15:24:21.431Z] 15:24:21     INFO -  PID 1599 |   "display": [
[task 2022-12-12T15:24:21.431Z] 15:24:21     INFO -  PID 1599 |     "marker-chart",
[task 2022-12-12T15:24:21.431Z] 15:24:21     INFO -  PID 1599 |     "marker-table",
[task 2022-12-12T15:24:21.431Z] 15:24:21     INFO -  PID 1599 |     "timeline-fileio"
[task 2022-12-12T15:24:21.431Z] 15:24:21     INFO -  PID 1599 |   ],
[task 2022-12-12T15:24:21.432Z] 15:24:21     INFO -  PID 1599 |   "data": [
[task 2022-12-12T15:24:21.432Z] 15:24:21     INFO -  PID 1599 |     {
[task 2022-12-12T15:24:21.432Z] 15:24:21     INFO -  PID 1599 |       "key": "operation",
[task 2022-12-12T15:24:21.432Z] 15:24:21     INFO -  PID 1599 |       "label": "Operation",
[task 2022-12-12T15:24:21.432Z] 15:24:21     INFO -  PID 1599 |       "format": "string",
[task 2022-12-12T15:24:21.432Z] 15:24:21     INFO -  PID 1599 |       "searchable": true
[task 2022-12-12T15:24:21.433Z] 15:24:21     INFO -  PID 1599 |     },
[task 2022-12-12T15:24:21.433Z] 15:24:21     INFO -  PID 1599 |     {
[task 2022-12-12T15:24:21.433Z] 15:24:21     INFO -  PID 1599 |       "key": "source",
[task 2022-12-12T15:24:21.433Z] 15:24:21     INFO -  PID 1599 |       "label": "Source",
[task 2022-12-12T15:24:21.433Z] 15:24:21     INFO -  PID 1599 |       "format": "string",
[task 2022-12-12T15:24:21.433Z] 15:24:21     INFO -  PID 1599 |       "searchable": true
[task 2022-12-12T15:24:21.434Z] 15:24:21     INFO -  PID 1599 |     },
[task 2022-12-12T15:24:21.434Z] 15:24:21     INFO -  PID 1599 |     {
[task 2022-12-12T15:24:21.434Z] 15:24:21     INFO -  PID 1599 |       "key": "filename",
[task 2022-12-12T15:24:21.434Z] 15:24:21     INFO -  PID 1599 |       "label": "Filename",
[task 2022-12-12T15:24:21.434Z] 15:24:21     INFO -  PID 1599 |       "format": "file-path",
[task 2022-12-12T15:24:21.434Z] 15:24:21     INFO -  PID 1599 |       "searchable": true
[task 2022-12-12T15:24:21.435Z] 15:24:21     INFO -  PID 1599 |     },
[task 2022-12-12T15:24:21.435Z] 15:24:21     INFO -  PID 1599 |     {
[task 2022-12-12T15:24:21.435Z] 15:24:21     INFO -  PID 1599 |       "key": "threadId",
[task 2022-12-12T15:24:21.435Z] 15:24:21     INFO -  PID 1599 |       "label": "Thread ID",
[task 2022-12-12T15:24:21.435Z] 15:24:21     INFO -  PID 1599 |       "format": "string",
[task 2022-12-12T15:24:21.435Z] 15:24:21     INFO -  PID 1599 |       "searchable": true
[task 2022-12-12T15:24:21.436Z] 15:24:21     INFO -  PID 1599 |     }
[task 2022-12-12T15:24:21.437Z] 15:24:21     INFO -  PID 1599 |   ]
[task 2022-12-12T15:24:21.437Z] 15:24:21     INFO -  PID 1599 | }
[task 2022-12-12T15:24:21.437Z] 15:24:21     INFO -  PID 1599 | -----------------------------------------------------
[task 2022-12-12T15:24:21.437Z] 15:24:21     INFO -  PID 1599 | A marker schema was not equal to expectations. If you
[task 2022-12-12T15:24:21.437Z] 15:24:21     INFO -  PID 1599 | are modifying the schema, then please copy and paste
[task 2022-12-12T15:24:21.438Z] 15:24:21     INFO -  PID 1599 | the new schema into this test.
[task 2022-12-12T15:24:21.438Z] 15:24:21     INFO -  PID 1599 | -----------------------------------------------------
[task 2022-12-12T15:24:21.438Z] 15:24:21     INFO -  PID 1599 | Copy this: {"name":"FileIO","display":["marker-chart","marker-table","timeline-fileio"],"data":[{"key":"operation","label":"Operation","format":"string","searchable":true},{"key":"source","label":"Source","format":"string","searchable":true},{"key":"filename","label":"Filename","format":"file-path","searchable":true},{"key":"threadId","label":"Thread ID","format":"string","searchable":true}]}
[task 2022-12-12T15:24:21.439Z] 15:24:21     INFO -  PID 1599 | -----------------------------------------------------
[task 2022-12-12T15:24:21.439Z] 15:24:21     INFO -  Unexpected exception NS_ERROR_ABORT:
[task 2022-12-12T15:24:21.439Z] 15:24:21     INFO -  _abort_failed_test@/builds/worker/workspace/build/tests/xpcshell/head.js:863:20
[task 2022-12-12T15:24:21.440Z] 15:24:21     INFO -  do_report_result@/builds/worker/workspace/build/tests/xpcshell/head.js:964:5
[task 2022-12-12T15:24:21.440Z] 15:24:21     INFO -  Assert<@/builds/worker/workspace/build/tests/xpcshell/head.js:71:21
[task 2022-12-12T15:24:21.441Z] 15:24:21     INFO -  Assert.prototype.report@resource://testing-common/Assert.sys.mjs:240:10
[task 2022-12-12T15:24:21.441Z] 15:24:21     INFO -  equal@resource://testing-common/Assert.sys.mjs:282:8
[task 2022-12-12T15:24:21.441Z] 15:24:21     INFO -  checkSchema@/builds/worker/workspace/build/tests/xpcshell/tests/tools/profiler/tests/xpcshell/head.js:211:12
[task 2022-12-12T15:24:21.441Z] 15:24:21     INFO -  @/builds/worker/workspace/build/tests/xpcshell/tests/tools/profiler/tests/xpcshell/test_feature_mainthreadio.js:25:16
[task 2022-12-12T15:24:21.442Z] 15:24:21     INFO -  _do_main@/builds/worker/workspace/build/tests/xpcshell/head.js:238:6
[task 2022-12-12T15:24:21.442Z] 15:24:21     INFO -  _execute_test@/builds/worker/workspace/build/tests/xpcshell/head.js:585:5
[task 2022-12-12T15:24:21.442Z] 15:24:21     INFO -  @-e:1:1
[task 2022-12-12T15:24:21.443Z] 15:24:21     INFO -  exiting test
[task 2022-12-12T15:24:21.443Z] 15:24:21     INFO -  <<<<<<<
[task 2022-12-12T15:24:21.443Z] 15:24:21     INFO -  INFO | Result summary:
[task 2022-12-12T15:24:21.443Z] 15:24:21     INFO -  INFO | Passed: 705
[task 2022-12-12T15:24:21.444Z] 15:24:21  WARNING -  INFO | Failed: 1
[task 2022-12-12T15:24:21.444Z] 15:24:21  WARNING -  One or more unittests failed.
[task 2022-12-12T15:24:21.444Z] 15:24:21     INFO -  INFO | Todo: 0
[task 2022-12-12T15:24:21.445Z] 15:24:21     INFO -  INFO | Retried: 1
[task 2022-12-12T15:24:21.445Z] 15:24:21     INFO -  SUITE-END | took 192s
[task 2022-12-12T15:24:21.445Z] 15:24:21     INFO -  Node moz-http2 server shutting down ...
[task 2022-12-12T15:24:21.445Z] 15:24:21     INFO -  http3Server server shutting down ...
[task 2022-12-12T15:24:21.566Z] 15:24:21    ERROR - Return code: 1
[task 2022-12-12T15:24:21.566Z] 15:24:21     INFO - TinderboxPrint: xpcshell-xpcshell<br/>705/<em class="testfail">1</em>/0
[task 2022-12-12T15:24:21.567Z] 15:24:21  WARNING - # TBPL FAILURE #
[task 2022-12-12T15:24:21.567Z] 15:24:21  WARNING - setting return code to 2
[task 2022-12-12T15:24:21.567Z] 15:24:21  WARNING - The xpcshell suite: xpcshell ran with return status: FAILURE

Flags: needinfo?(canaltinova)

Pulsebot

Comment 4

•

2 years ago

Pushed by canaltinova@gmail.com: https://hg.mozilla.org/integration/autoland/rev/f09a31130a8a Make some marker fields searchable and bump the profile version r=julienw

Nazım Can Altınova [:canova][:canaltinova on phabricator]

Assignee

Updated

•

2 years ago

Flags: needinfo?(canaltinova)

Narcis Beleuzu [:NarcisB]

Comment 5

•

2 years ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/f09a31130a8a

Status: ASSIGNED → RESOLVED

Closed: 2 years ago

status-firefox110: --- → fixed

Resolution: --- → FIXED

Target Milestone: --- → 110 Branch

Ryan VanderMeulen [:RyanVM]

Updated

•

2 years ago

status-firefox109: affected → wontfix

Bugzilla

Make some marker fields searchable in their marker schema

Categories

(Core :: Gecko Profiler, task, P2)

Tracking

()

People

(Reporter: canova, Assigned: canova)

References

Details

Crash Data

Security

(public)

User Story

Attachments

(1 file)

Description

Updated

Comment 1

Updated

Comment 2

Comment 3

Comment 4

Updated

Comment 5

Updated

Attachment

General

Description

File Name

Content Type