1803763 - Closed tab dismiss button tooltip says "Open ... in a new tab"

Status: VERIFIED FIXED

(Firefox :: Firefox View, defect)

Description

[Dão Gottwald [:dao]]

The dismiss button should have a dedicated tooltip instead of inheriting the list item's one. It looks like the button does have an aria-label; let's make that title instead which is automatically accessible?

Also the way the aria-label is built (${dismissLabel} ${tab.title}) seems like it's going to be wrong for various languages; not sure why flod removed fluent-reviewers from the patch?

Comment 1

[Francesco Lodolo [:flod]]

(In reply to Dão Gottwald [::dao] from comment #0)

Also the way the aria-label is built (${dismissLabel} ${tab.title}) seems like it's going to be wrong for various languages; not sure why flod removed fluent-reviewers from the patch?

The only explanation is that I opened the wrong phabricator link. I clearly remember opening the diff and there were no strings in the patch (in hindsight, probably looked at the partial diff), and assumed it was a missed rebase that triggered herald.

And you're correct, the whole string should be exposed (e.g. Dismiss ${tabTitle}), not just the partial.

Comment 2

[❌OOO Until Oct 7 ❌ Kelly Cochrane [:kcochrane]]

Sorry for the mixup here! I definitely see the value in switching from aria-label to title, so I'm working on fix for that and the other issue you've brought up. Thanks for catching that, Dao!

Comment 3

[❌OOO Until Oct 7 ❌ Kelly Cochrane [:kcochrane]]

Attachment: Bug 1803763 - Add title attribute to recently closed tab dismiss button r=dao

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6c9b61f0bdaf
Add title attribute to recently closed tab dismiss button r=dao,fluent-reviewers,flod

Comment 5

[Serban Stanca [:SerbanS]]

Backed out for causing bc failures on browser_recently_closed_tabs.js.

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | browser/components/firefoxview/tests/browser/browser_recently_closed_tabs.js | application terminated with exit code 11

Comment 6

[❌OOO Until Oct 7 ❌ Kelly Cochrane [:kcochrane]]

Attachment: fluent-error

Seeing this error when running a debug build. Looking into a fix now.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a2f9ac51b94b
Add title attribute to recently closed tab dismiss button r=dao,fluent-reviewers,flod

Comment 8

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/a2f9ac51b94b

Comment 9

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Reproduced the issue with Firefox 109.0a1 (2022-12-02) on Windows 10x64.
The issue is verified fixed with Firefox 109.0b3 on Windows 10x64, macOS 10.15 and Ubuntu 20.0.4. The Dismiss tab title tooltip is displayed when hovering over the dismiss button.