180384 - nsExternalHelperAppService should observe profile changes

Status: VERIFIED FIXED

(Core Graveyard :: File Handling, defect)

Description

[Boris Zbarsky [:bzbarsky]]

This is because we need to change to the new mimeTypes.rdf, mmkay?

Comment 1

[timeless]

Attachment: draft

i'm going away for a bit, but i figured i'd put something up so that people
would have it if they needed it. i haven't applied the profile change patch so
this is mostly untested, but it compiles and i think the program flow is
correct.

Comment 2

[Conrad Carlen (not reading bugmail)]

I have the patch for bug 97622 in my tree, tested this, and it works.

One thing though:

-  // we must be shutting down xpcom so remove our temporary files...
-  ExpungeTemporaryFiles();

This now happens in response to the profile shutting down, not XPCOM shutting
down. If that's the case, why is this observing XPCOM shutdown anyway - just to
remove itself as an observer? I think it's better just to use ownsWeak==PR_TRUE
with the observer service.

Comment 3

[Eugene Savitsky]

Should we mark this one with patch keyword?

Comment 4

[Boris Zbarsky [:bzbarsky]]

There is no such keyword.

Comment 5

[timeless]

Attachment: weak ref + handle failures

Comment 6

[Conrad Carlen (not reading bugmail)]

Comment on attachment 112250 [details] [diff] [review]
weak ref + handle failures

r=ccarlen. Fix this comment, though:
+  /* Add an observer for XPCOM shutdown and profile change*/

Comment 7

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 112250 [details] [diff] [review]
weak ref + handle failures

sr=dmose

Comment 8

[timeless]

checked in

Comment 9

[Chris Petersen]

Verified per last comments