1803863 - Minor clean up for table frame

Status: RESOLVED FIXED

(Core :: Layout: Tables, task)

Description

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

See the upcoming patches for details.

Comment 1

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1803863 Part 1 - Simplify nsTableFrame::SetupHeaderFooterChild(). r?#layout

The helper cannot fail, so we can return the height directly instead of using an
output argument.

Comment 2

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1803863 Part 2 - Make TableReflowInput's member vars conform with coding style. r?#layout

Depends on D163761

Comment 3

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1803863 Part 3 - Simplify the usages for ReflowOutput. r?#layout

• Remove unnecessary calls to ClearSize() after declaring a fresh ReflowOutput.
• Use ReflowOutput::SetSize() in nsTableFrame::FixupPositionedTableParts().

Depends on D163762

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/94713a5fbadf
Part 1 - Simplify nsTableFrame::SetupHeaderFooterChild(). r=emilio
https://hg.mozilla.org/integration/autoland/rev/f1123b6e0eed
Part 2 - Make TableReflowInput's member vars conform with coding style. r=emilio
https://hg.mozilla.org/integration/autoland/rev/7e2df6f0d1fd
Part 3 - Simplify the usages for ReflowOutput. r=emilio

Comment 5

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/94713a5fbadf
https://hg.mozilla.org/mozilla-central/rev/f1123b6e0eed
https://hg.mozilla.org/mozilla-central/rev/7e2df6f0d1fd